Skip to content

Add trailing comma in multiline RBS translation #661

Description

@jesse-shopify
      sig do
        params(backend_name: Symbol, api_surface: Symbol)
          .returns([T.any(LegacySearch, ShopLensSearch, FullContextSearch), T::Array[T::Hash[Symbol, T.untyped]]])
      end

Is currently:

      #: (
      #|   Symbol backend_name,
      #|   Symbol api_surface
      #| ) -> [(LegacySearch | ShopLensSearch | FullContextSearch), Array[Hash[Symbol, untyped]]]

but could be:

      #: (
      #|   Symbol backend_name,
      #|   Symbol api_surface,
      #| ) -> [(LegacySearch | ShopLensSearch | FullContextSearch), Array[Hash[Symbol, untyped]]]

Requested by @amomchilov

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions