Enable antialiasing by default in native Skia DOM (#1131)

Co-authored-by: William Candillon <[email protected]>
Shopify · Nov 21, 2022 · 47a5701 · 47a5701
1 parent 608747f
commit 47a5701
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/package/cpp/rnskia/RNSkDomView.cpp b/package/cpp/rnskia/RNSkDomView.cpp
@@ -84,8 +84,10 @@ void RNSkDomRenderer::renderCanvas(SkCanvas *canvas, float scaledWidth,
   canvas->scale(pd, pd);
 
   if (_drawingContext == nullptr) {
+    auto paint = std::make_shared<SkPaint>();
+    paint->setAntiAlias(true);
     _drawingContext =
-        std::make_shared<DrawingContext>(std::make_shared<SkPaint>(), 1.0f);
+        std::make_shared<DrawingContext>(paint, 1.0f);
 
     _drawingContext->setRequestRedraw([weakSelf = weak_from_this()]() {
       auto self = weakSelf.lock();

diff --git a/package/cpp/rnskia/dom/nodes/JsiPaintNode.h b/package/cpp/rnskia/dom/nodes/JsiPaintNode.h
@@ -37,7 +37,9 @@ class JsiPaintNode : public JsiBaseDomDeclarationNode,
     // ...and it should be a totally new paint, not inheriting from parent
     // paint.
     if (_localContext->isChanged()) {
-      _localContext->setMutablePaint(std::make_shared<SkPaint>());
+      auto paint = std::make_shared<SkPaint>();
+      paint->setAntiAlias(true);
+      _localContext->setMutablePaint(paint);
     }
 
     // Let's decorate paint props

diff --git a/package/cpp/rnskia/dom/props/BoxShadowProps.h b/package/cpp/rnskia/dom/props/BoxShadowProps.h
@@ -29,6 +29,7 @@ class BoxShadowProps : public DerivedProp<SkPaint> {
     SkScalar blur = _blurProp->value().getAsNumber();
 
     auto paint = SkPaint();
+    paint.setAntiAlias(true);
     paint.setColor(color);
     auto filter = SkMaskFilter::MakeBlur(kNormal_SkBlurStyle, blur, true);
     paint.setMaskFilter(filter);