From ef3f7314fa14feb2e4b8b5d88dc8d4bd86727579 Mon Sep 17 00:00:00 2001 From: Rahman Haroon <67966429+rahmanharoon@users.noreply.github.com> Date: Sun, 19 Dec 2021 21:22:34 +0530 Subject: [PATCH 1/3] typo fixes in readme.md --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 3ac5d189be..a5c5091343 100644 --- a/README.md +++ b/README.md @@ -4,14 +4,14 @@ Checkout the full documentation [here](https://shopify.github.io/react-native-skia). -React Native Skia brings the Skia Graphics Library to React Native. Skia serves as the graphics engine for Google Chrome and Chrome OS, Android, Flutter, Mozilla Firefox and, Firefox OS, and many other products. +React Native Skia brings the Skia Graphics Library to React Native. Skia serves as the graphics engine for Google Chrome and Chrome OS, Android, Flutter, Mozilla Firefox and Firefox OS, and many other products. *This is an alpha release. Use with caution.* ## Installation React Native Skia brings the [Skia Graphics Library](https://skia.org/) to React Native. -Skia serves as the graphics engine for Google Chrome and Chrome OS, Android, Flutter, Mozilla Firefox and, Firefox OS, and many other products. +Skia serves as the graphics engine for Google Chrome and Chrome OS, Android, Flutter, Mozilla Firefox and Firefox OS, and many other products. When reading these lines, the package is not yet available on npm. Use the link below to install the package. @@ -160,7 +160,7 @@ And then the _SDK Location_ section. It will show you the NDK path, or the optio - Run the commands in the `Building` section - Build the Android binaries with `yarn build-android` -- Build the NPM package with `yarn build-npm'; +- Build the NPM package with `yarn build-npm`; Publish the NPM package manually. The output is found in the `dist` folder. From 81463b2e6332c29a8188f7c3ba093bdea0c62181 Mon Sep 17 00:00:00 2001 From: Rahman Haroon <67966429+rahmanharoon@users.noreply.github.com> Date: Mon, 20 Dec 2021 12:10:55 +0530 Subject: [PATCH 2/3] cla registered --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a5c5091343..b80f0fedf9 100644 --- a/README.md +++ b/README.md @@ -132,7 +132,7 @@ Make sure to check out the sub modules: You also need to install some tools for the build scripts to work. Run `yarn` in the root of the project to install them. -Make sure you have all the tools required for building the skia libraries (XCode, Ninja, CMake, Android NDK / build tools) +Make sure you have all the tools required for building the skia libraries (XCode, Ninja, CMake, Android NDK / build tools). On MacOS you can install Ninja via homebrew: From 2b5af32e2ce4d2cb20eb587c035eb167077613c1 Mon Sep 17 00:00:00 2001 From: Rahman Haroon <67966429+rahmanharoon@users.noreply.github.com> Date: Mon, 20 Dec 2021 12:12:33 +0530 Subject: [PATCH 3/3] md fixes --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b80f0fedf9..a5c5091343 100644 --- a/README.md +++ b/README.md @@ -132,7 +132,7 @@ Make sure to check out the sub modules: You also need to install some tools for the build scripts to work. Run `yarn` in the root of the project to install them. -Make sure you have all the tools required for building the skia libraries (XCode, Ninja, CMake, Android NDK / build tools). +Make sure you have all the tools required for building the skia libraries (XCode, Ninja, CMake, Android NDK / build tools) On MacOS you can install Ninja via homebrew: