#1626: Fixing access to Skia Values from UI Thread (#1639)

* Fixing access to Skia Values from UI Thread

Previously the following would crash:

```ts
const x = useValue(50);
  const y = useValue(50);

  const gesture = useMemo(
    () =>
      Gesture.Pan().onChange(({ changeX, changeY }) => {
        x.current += changeX;
        y.current += changeY;
      }),
    []
  );
```

This was caused by the Skia Values storing its value in a JS object for fast access causing a crash when trying to write to this value from another runtime (REA / Main UI Thread)

This commit updates the Skia Value to use the JsiValue class instead - which unwraps / wraps the value to native primitives. There might be a small overhead doing this, but I've not been able to measure such a thing.

Fixes Skia value can't update on UI thread #1626

* Fix lint

* Fix ci

---------

Co-authored-by: William Candillon <[email protected]>

package/cpp/rnskia/values/RNSkReadonlyValue.h

@@ -11,7 +11,7 @@
 #include <jsi/jsi.h>
 
 #include "JsiSkHostObjects.h"
-#include "JsiValueWrapper.h"
+#include "JsiValue.h"
 #include "RNSkPlatformContext.h"
 
 namespace RNSkia {
@@ -29,8 +29,7 @@ class RNSkReadonlyValue
   explicit RNSkReadonlyValue(
       std::shared_ptr<RNSkPlatformContext> platformContext)
       : JsiSkHostObject(platformContext),
-        _valueHolder(std::make_shared<RNJsi::JsiValueWrapper>(
-            *platformContext->getJsRuntime())) {}
+        _valueHolder(std::make_shared<RNJsi::JsiValue>()) {}
 
   virtual ~RNSkReadonlyValue() { invalidate(); }
 
@@ -107,7 +106,7 @@ class RNSkReadonlyValue
    @param value Next value
    */
   virtual void update(jsi::Runtime &runtime, const jsi::Value &value) {
-    auto equal = _valueHolder->equals(runtime, value);
+    auto equal = _valueHolder->operator==(RNJsi::JsiValue(runtime, value));
     if (!equal) {
       _valueHolder->setCurrent(runtime, value);
       notifyListeners(runtime);
@@ -127,14 +126,14 @@ class RNSkReadonlyValue
    Returns the current value as a jsi::Value
    */
   jsi::Value getCurrent(jsi::Runtime &runtime) {
-    return _valueHolder->getCurrent(runtime);
+    return _valueHolder->getAsJsiValue(runtime);
   }
 
   /**
    Returns the underlying current value wrapper. This can be used to query the
    holder for data type and get pointers to elements in the holder.
    */
-  std::shared_ptr<RNJsi::JsiValueWrapper> getCurrent() { return _valueHolder; }
+  std::shared_ptr<RNJsi::JsiValue> getCurrent() { return _valueHolder; }
 
 protected:
   /**
@@ -158,7 +157,7 @@ class RNSkReadonlyValue
   }
 
 private:
-  std::shared_ptr<RNJsi::JsiValueWrapper> _valueHolder;
+  std::shared_ptr<RNJsi::JsiValue> _valueHolder;
 
   long _listenerId = 0;
   std::unordered_map<long, std::function<void(jsi::Runtime &)>> _listeners;