Merge pull request #1254 from Shopify/fix/1253-fix-missing-error-font…

…-prop #1253: Fixed missing error message if null guard is missing for font prop.
Shopify · Jan 6, 2023 · f666adf · f666adf
2 parents 36c3748 + 3e2fc05
commit f666adf
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/package/cpp/rnskia/dom/props/FontProp.h b/package/cpp/rnskia/dom/props/FontProp.h
@@ -15,7 +15,8 @@ class FontProp : public DerivedProp<SkFont> {
   }
 
   void updateDerivedValue() override {
-    if (_fontProp->value().getType() != PropType::HostObject) {
+    if (!_fontProp->isSet() ||
+        _fontProp->value().getType() != PropType::HostObject) {
       throw std::runtime_error("Expected SkFont object for the Font property.");
     }