fix(📏): substancial improvements on getting canvas sizes #3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcandillon
changed the title
onSize
Contributor
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@wcandillon Do you have any insight into what was happening here? We’re seeing the same issue with other libraries as well, and the workaround of just using useLayoutEffect feels more like a hack than a proper fix. Do you know what the underlying issue might be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3116
fixes #3222
Documentation at https://shopify.github.io/react-native-skia/docs/canvas/overview