Skip to content

Patch Performance/RedundantBlockCall to teach it about Sorbet sigs #200

Description

@sambostock

We disable Performance/RedundantBlockCall because "[it] conflicts with Sorbet since we need to capture the block to type it."

There is precedent for RuboCop extensions patching cops defined somewhere else, and this seems like a reasonable thing to patch. If the method definition is prefixed with a sig, this cop should not complain about capturing the block argument, even if yield is used.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help-wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions