Skip to content

Commit 5c59f2f

Browse files
authored
Add connected? method to runner client (#565)
Add a `connected?` method to `RunnerClient`, so that we can make checks without having to use `is_a?`. I also made `send_notification` and `make_request` private. They were not supposed to be public in the first place.
1 parent 99dace1 commit 5c59f2f

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

lib/ruby_lsp/ruby_lsp_rails/runner_client.rb

+12-2
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,13 @@ def stopped?
273273
[@stdin, @stdout, @stderr].all?(&:closed?) && !@wait_thread.alive?
274274
end
275275

276+
sig { returns(T::Boolean) }
277+
def connected?
278+
true
279+
end
280+
281+
private
282+
276283
sig do
277284
params(
278285
request: String,
@@ -288,8 +295,6 @@ def make_request(request, **params)
288295
sig { params(request: String, params: T.untyped).void }
289296
def send_notification(request, **params) = send_message(request, **params)
290297

291-
private
292-
293298
sig { overridable.params(request: String, params: T.untyped).void }
294299
def send_message(request, **params)
295300
message = { method: request }
@@ -398,6 +403,11 @@ def rails_root
398403
Dir.pwd
399404
end
400405

406+
sig { returns(T::Boolean) }
407+
def connected?
408+
false
409+
end
410+
401411
private
402412

403413
sig { params(message: ::String, type: ::Integer).void }

0 commit comments

Comments
 (0)