Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling pending migration prompt #570

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Allow disabling pending migration prompt #570

merged 1 commit into from
Feb 3, 2025

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Feb 3, 2025 •
edited by st0012
Loading

Closes #540

Allow disabling the pending migration prompt through an addon setting. To disable, users can add this to their configuration:

"rubyLsp.addonSettings": {
   "Ruby LSP Rails": {
     "enablePendingMigrationsPrompt": false
   }
 }

@vinistock Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock self-assigned this Feb 3, 2025
@vinistock vinistock requested review from andyw8 and st0012 February 3, 2025 20:41
@vinistock vinistock added the enhancement New feature or request label Feb 3, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review February 3, 2025 20:42
@vinistock vinistock requested a review from a team as a code owner February 3, 2025 20:42
@vinistock vinistock mentioned this pull request Feb 3, 2025
Closed
@vinistock vinistock force-pushed the 02-03-allow_disabling_pending_migration_prompt branch from 7bce071 to bbde54c Compare February 3, 2025 21:26
@vinistock vinistock requested a review from st0012 February 3, 2025 21:26
@vinistock vinistock merged commit d44779e into main Feb 3, 2025
29 checks passed
@vinistock Graphite App
Copy link
Member Author

Merge activity

  • Feb 3, 4:37 PM EST: A user merged this pull request with Graphite.

@vinistock vinistock deleted the 02-03-allow_disabling_pending_migration_prompt branch February 3, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@andyw8 andyw8 Awaiting requested review from andyw8

Assignees

@vinistock vinistock

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Migrations are pending" popup is too aggressive
3 participants
@vinistock @andyw8 @st0012