Address PR review feedback

- Remove redundant assert_match assertions in URI tests
- Extract escape_glob_metacharacters to RubyLsp module and reuse

Author: andriytyurnikov

lib/ruby_indexer/test/uri_test.rb

@@ -84,15 +84,11 @@ def test_from_path_with_unicode_characters
 
     def test_from_path_with_brackets
       uri = URI::Generic.from_path(path: "/some/path/[id].rb")
-      assert_match("%5B", uri.path)
-      assert_match("%5D", uri.path)
       assert_equal("file:///some/path/%5Bid%5D.rb", uri.to_s)
     end
 
     def test_from_path_with_braces
       uri = URI::Generic.from_path(path: "/some/path/{slug}.rb")
-      assert_match("%7B", uri.path)
-      assert_match("%7D", uri.path)
       assert_equal("file:///some/path/%7Bslug%7D.rb", uri.to_s)
     end
 

lib/ruby_lsp/listeners/completion.rb

@@ -457,7 +457,7 @@ def complete_require_relative(node)
         # if the path is not a directory, glob all possible next characters
         # for example ../somethi| (where | is the cursor position)
         # should find files for ../somethi*/
-        escaped_content = content.gsub(/[\[\]{}*?\\]/) { |c| "\\#{c}" }
+        escaped_content = RubyLsp.escape_glob_metacharacters(content)
         path_query = if content.end_with?("/") || content.empty?
           "#{escaped_content}**/*.rb"
         else

lib/ruby_lsp/requests/go_to_relevant_file.rb

@@ -115,7 +115,7 @@ def relevant_filename_patterns
 
       #: (String str) -> String
       def escape_glob_metacharacters(str)
-        str.gsub(/[\[\]{}*?\\]/) { |c| "\\#{c}" }
+        RubyLsp.escape_glob_metacharacters(str)
       end
 
       # Using the Jaccard algorithm to determine the similarity between the

lib/ruby_lsp/utils.rb

@@ -21,6 +21,12 @@ module RubyLsp
   GUESSED_TYPES_URL = "https://shopify.github.io/ruby-lsp/#guessed-types"
   TEST_PATH_PATTERN = "**/{test,spec,features}/**/{*_test.rb,test_*.rb,*_spec.rb,*.feature}"
 
+  # Escape characters that have special meaning in Dir.glob patterns
+  #: (String str) -> String
+  def self.escape_glob_metacharacters(str)
+    str.gsub(/[\[\]{}*?\\]/) { |c| "\\#{c}" }
+  end
+
   # Request delegation for embedded languages is not yet standardized into the language server specification. Here we
   # use this custom error class as a way to return a signal to the client that the request should be delegated to the
   # language server for the host language. The support for delegation is custom built on the client side, so each editor