Skip to content

Commit e27a04b

Browse files
committed
Do not instanciate generic classes with []
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
1 parent 46e0f4f commit e27a04b

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

lib/ruby_indexer/lib/ruby_indexer/index.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def initialize
6060
@entries = {} #: Hash[String, Array[Entry]]
6161

6262
# Holds all entries in the index using a prefix tree for searching based on prefixes to provide autocompletion
63-
@entries_tree = PrefixTree[T::Array[Entry]].new #: PrefixTree[Array[Entry]]
63+
@entries_tree = PrefixTree.new #: PrefixTree[Array[Entry]]
6464

6565
# Holds references to where entries where discovered so that we can easily delete them
6666
# {
@@ -71,7 +71,7 @@ def initialize
7171
@uris_to_entries = {} #: Hash[String, Array[Entry]]
7272

7373
# Holds all require paths for every indexed item so that we can provide autocomplete for requires
74-
@require_paths_tree = PrefixTree[URI::Generic].new #: PrefixTree[URI::Generic]
74+
@require_paths_tree = PrefixTree.new #: PrefixTree[URI::Generic]
7575

7676
# Holds the linearized ancestors list for every namespace
7777
@ancestors = {} #: Hash[String, Array[String]]

lib/ruby_indexer/test/prefix_tree_test.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def test_single_item
2222
end
2323

2424
def test_multiple_items
25-
tree = PrefixTree[String].new
25+
tree = PrefixTree.new #: PrefixTree[String]
2626
["foo", "bar", "baz"].each { |item| tree.insert(item, item) }
2727

2828
assert_equal(["baz", "bar", "foo"], tree.search(""))
@@ -34,7 +34,7 @@ def test_multiple_items
3434
end
3535

3636
def test_multiple_prefixes
37-
tree = PrefixTree[String].new
37+
tree = PrefixTree.new #: PrefixTree[String]
3838
["fo", "foo"].each { |item| tree.insert(item, item) }
3939

4040
assert_equal(["fo", "foo"], tree.search(""))
@@ -45,7 +45,7 @@ def test_multiple_prefixes
4545
end
4646

4747
def test_multiple_prefixes_with_shuffled_order
48-
tree = PrefixTree[String].new
48+
tree = PrefixTree.new #: PrefixTree[String]
4949
[
5050
"foo/bar/base",
5151
"foo/bar/on",
@@ -97,7 +97,7 @@ def test_multiple_prefixes_with_shuffled_order
9797
end
9898

9999
def test_deletion
100-
tree = PrefixTree[String].new
100+
tree = PrefixTree.new #: PrefixTree[String]
101101
["foo/bar", "foo/baz"].each { |item| tree.insert(item, item) }
102102
assert_equal(["foo/baz", "foo/bar"], tree.search("foo"))
103103

@@ -107,7 +107,7 @@ def test_deletion
107107
end
108108

109109
def test_delete_does_not_impact_other_keys_with_the_same_value
110-
tree = PrefixTree[String].new
110+
tree = PrefixTree.new #: PrefixTree[String]
111111
tree.insert("key1", "value")
112112
tree.insert("key2", "value")
113113
assert_equal(["value", "value"], tree.search("key"))
@@ -118,7 +118,7 @@ def test_delete_does_not_impact_other_keys_with_the_same_value
118118
end
119119

120120
def test_deleted_node_is_removed_from_the_tree
121-
tree = PrefixTree[String].new
121+
tree = PrefixTree.new #: PrefixTree[String]
122122
tree.insert("foo/bar", "foo/bar")
123123
assert_equal(["foo/bar"], tree.search("foo"))
124124

@@ -128,7 +128,7 @@ def test_deleted_node_is_removed_from_the_tree
128128
end
129129

130130
def test_deleting_non_terminal_nodes
131-
tree = PrefixTree[String].new
131+
tree = PrefixTree.new #: PrefixTree[String]
132132
tree.insert("abc", "value1")
133133
tree.insert("abcdef", "value2")
134134

@@ -138,7 +138,7 @@ def test_deleting_non_terminal_nodes
138138
end
139139

140140
def test_overriding_values
141-
tree = PrefixTree[Integer].new
141+
tree = PrefixTree.new #: PrefixTree[Integer]
142142

143143
tree.insert("foo/bar", 123)
144144
assert_equal([123], tree.search("foo/bar"))

0 commit comments

Comments
 (0)