Skip to content

Replace T.must with comment based syntax #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Replace T.must with comment based syntax #3400

merged 1 commit into from
Apr 24, 2025

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Apr 17, 2025 •
edited
Loading

Motivation

Migrate all of our T.must usage to the comment based RBS syntax.

@vinistock vinistock self-assigned this Apr 17, 2025
@vinistock vinistock requested review from alexcrocha, amomchilov, st0012 and a team April 17, 2025 09:06
@vinistock vinistock added dependencies dependencies ruby labels Apr 17, 2025 — with Graphite App
@vinistock vinistock mentioned this pull request Apr 17, 2025
Merged
@vinistock Graphite App
Copy link
Member Author

vinistock commented Apr 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock removed ruby dependencies dependencies labels Apr 17, 2025
@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Apr 17, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review April 17, 2025 09:07
Base automatically changed from 04-17-upgrade_sorbet_to_v0.5.12017 to main April 18, 2025 05:06
Morriar
Morriar approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

A few cosmetic suggestion but nothing blocking 👍

@vinistock vinistock force-pushed the 04-17-replace_t.must_with_comment_based_syntax branch from 65ea596 to 21c4d85 Compare April 24, 2025 16:14
@vinistock vinistock enabled auto-merge (squash) April 24, 2025 16:15
@vinistock vinistock merged commit 914a109 into main Apr 24, 2025
43 of 44 checks passed
@vinistock vinistock deleted the 04-17-replace_t.must_with_comment_based_syntax branch April 24, 2025 17:02
@BrewTestBot BrewTestBot mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriar Morriar Morriar approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha

@amomchilov amomchilov Awaiting requested review from amomchilov

@st0012 st0012 Awaiting requested review from st0012

Assignees

@vinistock vinistock

Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @Morriar