[ruby/rubygems] Report the gemrc cooldown from bundle config

The gemrc value takes part in resolving the cooldown but is not one of
the config layers, so `bundle config get cooldown` answered that nothing
was configured, then exited 1, while the cooldown was in force. It is
listed like a stored credential now, which is the other value the config
files do not hold.

ruby/rubygems@3d5179cd52

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: 2 people

lib/bundler/cli/config.rb

@@ -97,7 +97,7 @@ def run
             confirm(name)
           end
 
-          if current_value.nil? && !Bundler.settings.credential_stored?(name)
+          if current_value.nil? && !Bundler.settings.stored_outside_config_files?(name)
             exit 1
           else
             return

lib/bundler/settings.rb

@@ -187,6 +187,7 @@ def all_including_stored_credentials
       # The listing comes from the globally selected store, but a host can name
       # its own, so keep only the keys the per-host lookup agrees are set.
       keys.select! {|key| credential_stored?(key) }
+      keys << "cooldown" if gemrc_cooldown_days
 
       all.union(keys).sort
     end
@@ -258,10 +259,27 @@ def pretty_values_for(exposed_key)
         locations << "Set for the current user (#{global_config_file}): #{printable_value(value, exposed_key).inspect}"
       end
 
+      # The gemrc cooldown sits outside the priority order too. It is not one
+      # of the layers, it raises whatever they resolve to. See #cooldown_for.
+      if key == key_for(:cooldown) && (days = gemrc_cooldown_days)
+        line = "Set in the RubyGems configuration as `:cooldown:`: #{days}"
+        line += ". The longer of that and the top value applies" unless locations.empty?
+        locations << line
+      end
+
       return ["You have not configured a value for `#{exposed_key}`"] if locations.empty?
       locations
     end
 
+    ##
+    # True when +name+ has a configured value Settings#[] cannot see. A
+    # credential in the store is one, and so is the RubyGems `:cooldown:`
+    # setting that #cooldown_for raises the config layers to.
+
+    def stored_outside_config_files?(name)
+      credential_stored?(name) || (key_for(name) == key_for(:cooldown) && !gemrc_cooldown_days.nil?)
+    end
+
     ##
     # True when +name+'s credential lives in the credential store. The secret
     # itself is never returned: callers only need to know the setting exists,
@@ -441,6 +459,14 @@ def gemrc_cooldown
       nil
     end
 
+    # The gemrc cooldown as a usable number of days, or nil. A value that is
+    # not one takes no part in the resolution, so nothing reports it as
+    # configured either.
+
+    def gemrc_cooldown_days
+      cooldown_settings.days(rubygems_cooldown)
+    end
+
     def configs
       @configs ||= {
         temporary: @temporary,

spec/bundler/bundler/settings_spec.rb

@@ -136,6 +136,73 @@
       end
     end
 
+    describe "#pretty_values_for" do
+      it "reports a gemrc cooldown that no Bundler layer configures" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, 7)
+
+        expect(settings.pretty_values_for(:cooldown)).to eq(
+          ["Set in the RubyGems configuration as `:cooldown:`: 7"]
+        )
+      end
+
+      it "explains the max rule only when a Bundler layer configures one too" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, 7)
+        settings.set_local :cooldown, "3"
+
+        expect(settings.pretty_values_for(:cooldown).last).to eq(
+          "Set in the RubyGems configuration as `:cooldown:`: 7. The longer of that and the top value applies"
+        )
+      end
+
+      it "leaves out a gemrc value that takes no part in the resolution" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, "abc")
+        allow(Bundler.ui).to receive(:warn)
+
+        expect(settings.pretty_values_for(:cooldown)).to eq(["You have not configured a value for `cooldown`"])
+      end
+
+      it "says nothing about RubyGems when it configures no cooldown" do
+        allow(Gem.configuration).to receive(:each)
+
+        expect(settings.pretty_values_for(:cooldown)).to eq(["You have not configured a value for `cooldown`"])
+      end
+    end
+
+    describe "#stored_outside_config_files?" do
+      it "is true for a cooldown only the gemrc configures" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, 7)
+
+        expect(settings.stored_outside_config_files?(:cooldown)).to be true
+      end
+
+      it "is false for a gemrc value that takes no part in the resolution" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, "abc")
+        allow(Bundler.ui).to receive(:warn)
+
+        expect(settings.stored_outside_config_files?(:cooldown)).to be false
+      end
+
+      it "is false for another key the gemrc knows nothing about" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, 7)
+
+        expect(settings.stored_outside_config_files?(:jobs)).to be false
+      end
+    end
+
+    describe "#all_including_stored_credentials" do
+      it "lists a cooldown only the gemrc configures" do
+        allow(Gem.configuration).to receive(:each).and_yield(:cooldown, 7)
+
+        expect(settings.all_including_stored_credentials).to include("cooldown")
+      end
+
+      it "leaves it out when the gemrc configures none" do
+        allow(Gem.configuration).to receive(:each)
+
+        expect(settings.all_including_stored_credentials).not_to include("cooldown")
+      end
+    end
+
     describe "#rubygems_cooldown" do
       it "warns once when the gemrc value is not a number" do
         allow(Gem.configuration).to receive(:each).and_yield(:cooldown, "abc")