Skip to content

Commit ac8d936

Browse files
committed
ZJIT: [DOC] Remove comment and done TODO about lightweight frame
The TODO is done and ZJIT sets `cfp->jit_return` now. As a side benefit, we now provide higher fidelity PC data to the `rb_profile_frames()`.
1 parent 69e2257 commit ac8d936

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

vm_backtrace.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2107,10 +2107,6 @@ thread_profile_frames(rb_execution_context_t *ec, int start, int limit, VALUE *b
21072107
// may leave it uninitialized for speed. JIT code must update the PC
21082108
// before entering a non-leaf method (so that `caller` will work),
21092109
// so only the topmost frame could possibly have an out-of-date PC.
2110-
// ZJIT doesn't set `cfp->jit_return`, so it's not a reliable signal.
2111-
// TODO(zjit): lightweight frames potentially makes more than
2112-
// the top most frame invalid.
2113-
//
21142110
// Avoid passing invalid PC to calc_lineno() to avoid crashing.
21152111
if (cfp == top && (pc < iseq_encoded || pc > pc_end)) {
21162112
lines[i] = 0;

0 commit comments

Comments
 (0)