Skip to content

Commit 61ae2ef

Browse files
authored
Upgrade Prism to v1.6.0 (#323)
Upgrade to the latest Prism version. The new version made Clippy realize that we were invoking `iter` on a few places where it isn't necessary and flagged it as less efficient than just iterating over a reference. I fixed all of those.
1 parent 14b229b commit 61ae2ef

File tree

3 files changed

+27
-79
lines changed

3 files changed

+27
-79
lines changed

rust/Cargo.lock

Lines changed: 20 additions & 72 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/saturn/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ path = "src/main.rs"
1212
crate-type = ["rlib"]
1313

1414
[dependencies]
15-
ruby-prism = "1.4.0"
15+
ruby-prism = "1.6.0"
1616
url = "2.5.4"
1717
xxhash-rust = { version = "0.8.15", features = ["xxh3"] }
1818
clap = { version = "4.5.16", features = ["derive"] }

rust/saturn/src/indexing/ruby_indexer.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ impl<'a> RubyIndexer<'a> {
120120
let mut parameters: Vec<Parameter> = Vec::new();
121121

122122
if let Some(parameters_list) = node.parameters() {
123-
for parameter in parameters_list.requireds().iter() {
123+
for parameter in &parameters_list.requireds() {
124124
let location = parameter.location();
125125

126126
parameters.push(Parameter::RequiredPositional(ParameterStruct::new(
@@ -129,7 +129,7 @@ impl<'a> RubyIndexer<'a> {
129129
)));
130130
}
131131

132-
for parameter in parameters_list.optionals().iter() {
132+
for parameter in &parameters_list.optionals() {
133133
let opt_param = parameter.as_optional_parameter_node().unwrap();
134134
let name_loc = opt_param.name_loc();
135135

@@ -149,7 +149,7 @@ impl<'a> RubyIndexer<'a> {
149149
)));
150150
}
151151

152-
for post in parameters_list.posts().iter() {
152+
for post in &parameters_list.posts() {
153153
let location = post.location();
154154

155155
parameters.push(Parameter::Post(ParameterStruct::new(
@@ -158,7 +158,7 @@ impl<'a> RubyIndexer<'a> {
158158
)));
159159
}
160160

161-
for keyword in parameters_list.keywords().iter() {
161+
for keyword in &parameters_list.keywords() {
162162
match keyword {
163163
ruby_prism::Node::RequiredKeywordParameterNode { .. } => {
164164
let required = keyword.as_required_keyword_parameter_node().unwrap();
@@ -234,7 +234,7 @@ impl<'a> RubyIndexer<'a> {
234234
if (receiver.is_none() || receiver.unwrap().as_self_node().is_some())
235235
&& let Some(arguments) = node.arguments()
236236
{
237-
for argument in arguments.arguments().iter() {
237+
for argument in &arguments.arguments() {
238238
match argument {
239239
ruby_prism::Node::SymbolNode { .. } => {
240240
let symbol = argument.as_symbol_node().unwrap();
@@ -590,7 +590,7 @@ impl Visit<'_> for RubyIndexer<'_> {
590590
}
591591

592592
fn visit_multi_write_node(&mut self, node: &ruby_prism::MultiWriteNode) {
593-
for left in node.lefts().iter() {
593+
for left in &node.lefts() {
594594
match left {
595595
ruby_prism::Node::ConstantTargetNode { .. } | ruby_prism::Node::ConstantPathTargetNode { .. } => {
596596
let location = left.location();

0 commit comments

Comments
 (0)