Replace JS implementation with TypeScript shop-cli (@shopify/shop-cli) - #4
Merged
Conversation
Imports the catalog-cli version of the Shop CLI skill: - TypeScript source (tsup build, vitest, keytar OS-keychain token storage) - package/ with src + tests, SKILL.md, references/ (catalog-mcp, direct-api, safety, legal) - Renames package to @shopify/shop-cli - Excludes build artifacts and debug response dumps 56/56 tests pass; typecheck clean.
🔍 Denylist Analysis ResultsAnalyzed 41 packages. package/pnpm-lock.yaml✅ Known Packages - Approved for Use (41)
⏳ Package Age Warnings❓ Packages With Unknown Age (1) — unable to determine publish date
For any questions or to provide feedback, please reach out to #help-bumperbot. Generated by Bumperbot. |
Removes the two heaviest dev-dependency trees from the supply chain: - tsup -> tsc (tsconfig.build.json emits dist/; shebang now lives in src/bin.ts, which tsc preserves; build chmod +x's the bin) - vitest -> node:test + node:assert via a small tests/harness.ts shim (expect/fn/.not/.resolves/.rejects + the matchers this suite uses). tsconfig.test.json compiles to .test-build/ and 'node --test' runs it. Effect: node_modules/.pnpm drops 126 -> 43; eliminates tinyspy and @types/estree@1.0.9 (both flagged entering the supply chain) along with rollup/esbuild/vite. Runtime deps unchanged (commander + keytar). Also syncs current source for cli.ts (buyer-ip help text) and shop-client.ts (assertCheckoutCompleted verifies complete_checkout actually returned a completed checkout). Renames package to @shopify/shop-cli. typecheck clean; 57/57 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the current JS implementation (
bin/shop.mjs+lib/*.mjs, packageshopv1.0.1) with the catalog-cli TypeScript version of the Shop CLI skill.Contents
package/— TypeScript source (src/) + tests (tests/), tsup build, vitest, keytar (OS-keychain token storage)SKILL.md— skill instructionsreferences/—catalog-mcp.md,direct-api.md,safety.md,legal.md@shopify/shop-cliExcluded intentionally
node_modules/,dist/(build artifacts;pnpm buildregeneratesdist)ucp-bug-repro/debug response dumps (contained real catalog response data)Validation
pnpm typecheck— cleanpnpm test— 56/56 passing