-
Notifications
You must be signed in to change notification settings - Fork 196
Open
Description
Overview
This log message:
logger.info('Authenticating admin request', {
shop: getShopFromRequest(request),
});
Link to the location of the log
Fills my logs with null. I actually don't mind it, if shop were populated, but it's kinda silly to have it claim to have a value and have it be null. Especially since a couple of lines later the debug log actually does print shop and sessionId - an eminently more useful log, at a lower visibility level. If we don't want to put shop sessionId in production for customer privacy reasons, at least delete the context parameter that is always null because shop is not in the query parameters anymore? Thanks!
Metadata
Metadata
Assignees
Labels
No labels