Skip to content

Commit 934dc2b

Browse files
authored
Fix extension no longer working after latest release (#93)
* Add svg attributes that broke built * Fix webpack issue * version bump
1 parent ed8bd87 commit 934dc2b

10 files changed

+1177
-1306
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Change Log
22

3+
## v2.0.3 (Apr. 29, 2021)
4+
* [#93](https://github.com/Shopify/shopify-theme-inspector/pull/93) Fix extension due to broken minification
5+
36
## v2.0.2 (Apr. 26, 2021)
47
* [#87](https://github.com/Shopify/shopify-theme-inspector/pull/87) Security update packages
58

package.json

+6-2
Original file line numberDiff line numberDiff line change
@@ -35,26 +35,30 @@
3535
"d3": "^5.16.0",
3636
"d3-flame-graph": "^2.2.2",
3737
"jsdom": "^15.2.1",
38+
"lodash.debounce": "^4.0.8",
39+
"lodash.escape": "^4.0.1",
3840
"nullthrows": "^1.1.1",
3941
"stream-browserify": "^3.0.0"
4042
},
4143
"devDependencies": {
4244
"@types/chrome": "^0.0.91",
4345
"@types/jest": "^24.9.1",
4446
"@types/jest-environment-puppeteer": "^4.4.1",
45-
"@types/lodash": "^4.14.168",
47+
"@types/lodash.debounce": "^4.0.6",
48+
"@types/lodash.escape": "^4.0.6",
4649
"@types/puppeteer": "^1.20.7",
4750
"clean-webpack-plugin": "^3.0.0",
51+
"closure-webpack-plugin": "^2.5.0",
4852
"css-loader": "^3.6.0",
4953
"eslint": "^6.8.0",
5054
"eslint-plugin-shopify": "^30.0.1",
55+
"google-closure-compiler": "^20210406.0.0",
5156
"html-webpack-inline-svg-plugin": "^2.3.0",
5257
"html-webpack-plugin": "^5.3.1",
5358
"identity-obj-proxy": "^3.0.0",
5459
"jest": "^24.9.0",
5560
"jest-fetch-mock": "^2.1.2",
5661
"jest-puppeteer": "^5.0.2",
57-
"lodash": "^4.17.21",
5862
"mini-css-extract-plugin": "^1.5.0",
5963
"prettier": "^1.19.1",
6064
"puppeteer": "^9.0.0",

src/components/liquid-flamegraph.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import * as d3 from 'd3';
22
import * as flamegraph from 'd3-flame-graph';
33
import 'd3-flame-graph/dist/d3-flamegraph.css';
4-
import {debounce, escape} from 'lodash';
4+
import debounce from 'lodash.debounce';
5+
import escape from 'lodash.escape';
56
import {
67
formatNodeTime,
78
getThemeId,

src/devtools.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {escape} from 'lodash';
1+
import escape from 'lodash.escape';
22
import {RenderBackend} from './env';
33
import Toolbar from './components/toolbar';
44
import LiquidFlamegraph from './components/liquid-flamegraph';

src/images/refresh-arrow.svg

+1-1
Loading

src/images/zoom-out.svg

+1-1
Loading

src/manifest.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Shopify Theme Inspector for Chrome",
3-
"version": "2.0.2",
3+
"version": "2.0.3",
44
"description": "Profile and debug Liquid template on your Shopify store",
55
"devtools_page": "devtools.html",
66
"permissions": ["storage", "identity", "activeTab"],

webpack.common.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module.exports = {
1111
fallback: {
1212
"stream": require.resolve("stream-browserify"),
1313
"crypto": require.resolve('crypto-browserify'),
14-
"buffer": require.resolve("buffer/")
14+
"buffer": require.resolve("buffer")
1515
}
1616
},
1717
entry: {

webpack.prod.js

+6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
const merge = require('webpack-merge');
22
const common = require('./webpack.common.js');
3+
const ClosurePlugin = require('closure-webpack-plugin');
34

45
module.exports = merge(common, {
56
mode: 'production',
7+
optimization: {
8+
minimizer: [
9+
new ClosurePlugin({mode: 'STANDARD'})
10+
]
11+
}
612
});

0 commit comments

Comments
 (0)