rubo cop

Author: lizkenyon

lib/shopify_app/managers/script_tags_manager.rb

@@ -56,7 +56,10 @@ def create_script_tags(session:)
         if template_types_to_check.all? do |template_type|
              template_supports_app_blocks?(active_theme["id"], template_type)
            end
-          ShopifyApp::Logger.info("Theme supports app blocks for templates: #{template_types_to_check.join(", ")}. Skipping script tag creation.")
+          ShopifyApp::Logger.info(
+            "Theme supports app blocks for templates: #{template_types_to_check.join(", ")}. " \
+              "Skipping script tag creation.",
+          )
           return
         end
       end
@@ -349,7 +352,9 @@ def fetch_all_script_tags
         end
 
         # Handle nil data or missing structure
-        return [] unless response.body["data"] && response.body["data"]["scriptTags"] && response.body["data"]["scriptTags"]["edges"]
+        return [] unless response.body["data"] &&
+          response.body["data"]["scriptTags"] &&
+          response.body["data"]["scriptTags"]["edges"]
 
         response.body["data"]["scriptTags"]["edges"].map { |edge| edge["node"] }
       rescue => e

test/shopify_app/managers/script_tags_manager_test.rb

@@ -66,7 +66,11 @@ class ShopifyApp::ScriptTagsManagerTest < ActiveSupport::TestCase
     })
 
     # Set up the sequence of responses
-    @mock_client.stubs(:query).returns(empty_response).then.returns(success_response).then.returns(success_response).then.returns(success_response)
+    @mock_client.stubs(:query)
+      .returns(empty_response)
+      .then.returns(success_response)
+      .then.returns(success_response)
+      .then.returns(success_response)
 
     @manager.create_script_tags(session: @session)
 
@@ -453,7 +457,13 @@ class ShopifyApp::ScriptTagsManagerTest < ActiveSupport::TestCase
     # Set up the sequence of responses for the GraphQL client
     # The code will stop checking templates once it finds one that doesn't support app blocks
     # So we only need to set up expectations for the queries that will actually be made
-    @mock_client.stubs(:query).returns(theme_response).then.returns(product_template_response).then.returns(product_section_response).then.returns(collection_template_response).then.returns(collection_section_response).then.returns(empty_script_tags_response)
+    @mock_client.stubs(:query)
+      .returns(theme_response)
+      .then.returns(product_template_response)
+      .then.returns(product_section_response)
+      .then.returns(collection_template_response)
+      .then.returns(collection_section_response)
+      .then.returns(empty_script_tags_response)
 
     # Expect script tag creation calls
     expect_script_tag_creation("https://example-app.com/fancy.js")