Merge pull request #989 from Shopify/at-code-metrics-sorbet-types

Collect T::Struct and T::Enum code metrics

Author: Morriar

lib/spoom/sorbet/metrics/code_metrics_visitor.rb

@@ -73,6 +73,13 @@ def visit(node)
         # @override
         #: (Prism::ClassNode) -> void
         def visit_class_node(node)
+          case node.superclass&.slice
+          when /^(::)?T::Struct$/
+            @counters.increment("t_structs")
+          when /^(::)?T::Enum$/
+            @counters.increment("t_enums")
+          end
+
           visit_scope(node) do
             super
           end

test/spoom/sorbet/metrics/code_metrics_visitor_test.rb

@@ -34,6 +34,22 @@ def bar; end
           assert_equal(1, metrics["accessors"])
         end
 
+        def test_collects_metrics_about_sorbet_structs_and_enums
+          metrics = collect_metrics do |context|
+            context.write!("foo.rb", <<~RUBY)
+              class Struct < T::Struct; end
+              class RootStruct < ::T::Struct; end
+              class Enum < T::Enum; end
+              class RootEnum < ::T::Enum; end
+              class Other; end
+            RUBY
+          end
+
+          assert_equal(5, metrics["classes"])
+          assert_equal(2, metrics["t_structs"])
+          assert_equal(2, metrics["t_enums"])
+        end
+
         def test_collects_metrics_about_sigs
           metrics = collect_metrics do |context|
             context.write!("foo.rb", <<~RUBY)