Add force option to RBS comment translation

Author: Morriar

lib/spoom/sorbet/translate.rb

@@ -60,15 +60,16 @@ def sorbet_sigs_to_rbs_comments(
         # Converts all the RBS comments in the given Ruby code to `sig` nodes.
         # It also handles type members and class annotations.
         #: (String ruby_contents, file: String, ?max_line_length: Integer?,
-        #| ?overloads_strategy: Symbol, ?erase_generic_types: bool) -> String
+        #| ?overloads_strategy: Symbol, ?erase_generic_types: bool, ?force: bool) -> String
         def rbs_comments_to_sorbet_sigs(ruby_contents, file:, max_line_length: nil, overloads_strategy: :translate_all,
-          erase_generic_types: false)
+          erase_generic_types: false, force: false)
           RBSCommentsToSorbetSigs.rewrite_if_needed(
             ruby_contents,
             file: file,
             max_line_length: max_line_length,
             overloads_strategy: overloads_strategy,
             erase_generic_types: erase_generic_types,
+            force: force,
           )
         end
 

lib/spoom/sorbet/translate/rbs_comments_to_sorbet_sigs.rb

@@ -29,15 +29,18 @@ def contains_rbs_syntax?(source)
           #|   file: String,
           #|   ?max_line_length: Integer?,
           #|   ?overloads_strategy: Symbol,
-          #|   ?erase_generic_types: bool) -> String
+          #|   ?erase_generic_types: bool,
+          #|   ?force: bool) -> String
           def rewrite_if_needed(
             ruby_contents,
             file:,
             max_line_length: nil,
             overloads_strategy: :translate_all,
-            erase_generic_types: false
+            erase_generic_types: false,
+            force: false
           )
-            return ruby_contents unless contains_rbs_syntax?(ruby_contents)
+            return ruby_contents unless ruby_contents.match?(RBS_REWRITE_PATTERN) &&
+              (force || Sigils.contains_valid_sigil?(ruby_contents))
 
             options = Options.new(
               overloads_strategy:,

rbi/spoom.rbi

@@ -3241,10 +3241,11 @@ module Spoom::Sorbet::Translate
         file: ::String,
         max_line_length: T.nilable(::Integer),
         overloads_strategy: ::Symbol,
-        erase_generic_types: T::Boolean
+        erase_generic_types: T::Boolean,
+        force: T::Boolean
       ).returns(::String)
     end
-    def rbs_comments_to_sorbet_sigs(ruby_contents, file:, max_line_length: T.unsafe(nil), overloads_strategy: T.unsafe(nil), erase_generic_types: T.unsafe(nil)); end
+    def rbs_comments_to_sorbet_sigs(ruby_contents, file:, max_line_length: T.unsafe(nil), overloads_strategy: T.unsafe(nil), erase_generic_types: T.unsafe(nil), force: T.unsafe(nil)); end
 
     sig do
       params(
@@ -3324,10 +3325,11 @@ module Spoom::Sorbet::Translate::RBSCommentsToSorbetSigs
         file: ::String,
         max_line_length: T.nilable(::Integer),
         overloads_strategy: ::Symbol,
-        erase_generic_types: T::Boolean
+        erase_generic_types: T::Boolean,
+        force: T::Boolean
       ).returns(::String)
     end
-    def rewrite_if_needed(ruby_contents, file:, max_line_length: T.unsafe(nil), overloads_strategy: T.unsafe(nil), erase_generic_types: T.unsafe(nil)); end
+    def rewrite_if_needed(ruby_contents, file:, max_line_length: T.unsafe(nil), overloads_strategy: T.unsafe(nil), erase_generic_types: T.unsafe(nil), force: T.unsafe(nil)); end
   end
 end
 

test/spoom/sorbet/translate/rbs_comments_to_sorbet_sigs_test.rb

@@ -1597,6 +1597,18 @@ def foo; end
           end
         end
 
+        def test_rewrite_force_translates_files_without_typed_sigil
+          source = <<~RB
+            #: -> void
+            def foo; end
+          RB
+
+          assert_equal(<<~RB, RBSCommentsToSorbetSigs.rewrite_if_needed(source, file: "test.rb", force: true))
+            sig { void }
+            def foo; end
+          RB
+        end
+
         private
 
         #: (String,