Skip to content

Add a test showing RBS signatures are being deleted by the deadcode remover - #773

Closed
Morriar wants to merge 1 commit into
mainfrom
at-deadcode-rbs
Closed

Add a test showing RBS signatures are being deleted by the deadcode remover#773
Morriar wants to merge 1 commit into
mainfrom
at-deadcode-rbs

Conversation

@Morriar

@Morriar Morriar commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

@shioyama it looks like it works. Do you have an example where it didn't?

…remover

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar self-assigned this Jun 27, 2025
@Morriar
Morriar requested a review from a team as a code owner June 27, 2025 13:13
@Morriar Morriar added the chore Chore task label Jun 27, 2025

@KaanOzkan KaanOzkan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can close since we have

def test_removes_node_with_comments
res = remove(<<~RB, "bar")
class Foo
def foo; end
# Some comments
# related
# to bar
def bar
something
end
def baz; end
end
RB
assert_equal(<<~RB, res)
class Foo
def foo; end
def baz; end
end
RB
end

@Morriar

Morriar commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Very stale

@Morriar Morriar closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants