Skip to content

Commit 6efbfb7

Browse files
committed
[Experiment] Use older Minitest for older Rails versions
1 parent eb04d94 commit 6efbfb7

2 files changed

Lines changed: 68 additions & 56 deletions

File tree

Gemfile

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ gemspec
77
CURRENT_RAILS_VERSION = "8.1"
88
rails_version = ENV.fetch("RAILS_VERSION", CURRENT_RAILS_VERSION)
99

10-
gem "minitest", "< 7.0" # Rails 8.1.1 doesn't support minitest 6.0 which causes errors
1110
gem "minitest-hooks"
1211
gem "minitest-reporters"
1312
gem "debug"
@@ -25,9 +24,22 @@ end
2524
group :development, :test do
2625
if rails_version == "main"
2726
gem "rails", github: "rails/rails", branch: "main"
27+
gem "minitest", "< 7.0"
2828
else
2929
rails_version = CURRENT_RAILS_VERSION if rails_version == "current"
30-
gem "rails", "~> #{rails_version}.0"
30+
31+
if rails_version == "8.1"
32+
rails_version = "8.1.2"
33+
gem "rails", "~> 8.1.2" # Fixes support for Minitest 6.0
34+
else
35+
gem "rails", "~> #{rails_version}.0"
36+
end
37+
38+
if Gem::Version.new(rails_version) < Gem::Version.new("8.1.2")
39+
gem "minitest", "< 6.0" # Don't use Minitest 6 for Rails versions older than 8.1.2
40+
else
41+
gem "minitest", "< 7.0" # Rails 8.1.1 doesn't support minitest 6.0 which causes errors
42+
end
3143
end
3244

3345
gem "sqlite3"

Gemfile.lock

Lines changed: 54 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -34,76 +34,76 @@ GEM
3434
concurrent-ruby (~> 1.0)
3535
action_text-trix (2.1.16)
3636
railties
37-
actioncable (8.1.1)
38-
actionpack (= 8.1.1)
39-
activesupport (= 8.1.1)
37+
actioncable (8.1.2)
38+
actionpack (= 8.1.2)
39+
activesupport (= 8.1.2)
4040
nio4r (~> 2.0)
4141
websocket-driver (>= 0.6.1)
4242
zeitwerk (~> 2.6)
43-
actionmailbox (8.1.1)
44-
actionpack (= 8.1.1)
45-
activejob (= 8.1.1)
46-
activerecord (= 8.1.1)
47-
activestorage (= 8.1.1)
48-
activesupport (= 8.1.1)
43+
actionmailbox (8.1.2)
44+
actionpack (= 8.1.2)
45+
activejob (= 8.1.2)
46+
activerecord (= 8.1.2)
47+
activestorage (= 8.1.2)
48+
activesupport (= 8.1.2)
4949
mail (>= 2.8.0)
50-
actionmailer (8.1.1)
51-
actionpack (= 8.1.1)
52-
actionview (= 8.1.1)
53-
activejob (= 8.1.1)
54-
activesupport (= 8.1.1)
50+
actionmailer (8.1.2)
51+
actionpack (= 8.1.2)
52+
actionview (= 8.1.2)
53+
activejob (= 8.1.2)
54+
activesupport (= 8.1.2)
5555
mail (>= 2.8.0)
5656
rails-dom-testing (~> 2.2)
57-
actionpack (8.1.1)
58-
actionview (= 8.1.1)
59-
activesupport (= 8.1.1)
57+
actionpack (8.1.2)
58+
actionview (= 8.1.2)
59+
activesupport (= 8.1.2)
6060
nokogiri (>= 1.8.5)
6161
rack (>= 2.2.4)
6262
rack-session (>= 1.0.1)
6363
rack-test (>= 0.6.3)
6464
rails-dom-testing (~> 2.2)
6565
rails-html-sanitizer (~> 1.6)
6666
useragent (~> 0.16)
67-
actiontext (8.1.1)
67+
actiontext (8.1.2)
6868
action_text-trix (~> 2.1.15)
69-
actionpack (= 8.1.1)
70-
activerecord (= 8.1.1)
71-
activestorage (= 8.1.1)
72-
activesupport (= 8.1.1)
69+
actionpack (= 8.1.2)
70+
activerecord (= 8.1.2)
71+
activestorage (= 8.1.2)
72+
activesupport (= 8.1.2)
7373
globalid (>= 0.6.0)
7474
nokogiri (>= 1.8.5)
75-
actionview (8.1.1)
76-
activesupport (= 8.1.1)
75+
actionview (8.1.2)
76+
activesupport (= 8.1.2)
7777
builder (~> 3.1)
7878
erubi (~> 1.11)
7979
rails-dom-testing (~> 2.2)
8080
rails-html-sanitizer (~> 1.6)
81-
activejob (8.1.1)
82-
activesupport (= 8.1.1)
81+
activejob (8.1.2)
82+
activesupport (= 8.1.2)
8383
globalid (>= 0.3.6)
84-
activemodel (8.1.1)
85-
activesupport (= 8.1.1)
84+
activemodel (8.1.2)
85+
activesupport (= 8.1.2)
8686
activemodel-serializers-xml (1.0.3)
8787
activemodel (>= 5.0.0.a)
8888
activesupport (>= 5.0.0.a)
8989
builder (~> 3.1)
90-
activerecord (8.1.1)
91-
activemodel (= 8.1.1)
92-
activesupport (= 8.1.1)
90+
activerecord (8.1.2)
91+
activemodel (= 8.1.2)
92+
activesupport (= 8.1.2)
9393
timeout (>= 0.4.0)
9494
activerecord-typedstore (1.6.0)
9595
activerecord (>= 6.1)
9696
activeresource (6.2.0)
9797
activemodel (>= 7.0)
9898
activemodel-serializers-xml (~> 1.0)
9999
activesupport (>= 7.0)
100-
activestorage (8.1.1)
101-
actionpack (= 8.1.1)
102-
activejob (= 8.1.1)
103-
activerecord (= 8.1.1)
104-
activesupport (= 8.1.1)
100+
activestorage (8.1.2)
101+
actionpack (= 8.1.2)
102+
activejob (= 8.1.2)
103+
activerecord (= 8.1.2)
104+
activesupport (= 8.1.2)
105105
marcel (~> 1.0)
106-
activesupport (8.1.1)
106+
activesupport (8.1.2)
107107
base64
108108
bigdecimal
109109
concurrent-ruby (~> 1.0, >= 1.3.1)
@@ -271,30 +271,30 @@ GEM
271271
rack (>= 1.3)
272272
rackup (2.3.1)
273273
rack (>= 3)
274-
rails (8.1.1)
275-
actioncable (= 8.1.1)
276-
actionmailbox (= 8.1.1)
277-
actionmailer (= 8.1.1)
278-
actionpack (= 8.1.1)
279-
actiontext (= 8.1.1)
280-
actionview (= 8.1.1)
281-
activejob (= 8.1.1)
282-
activemodel (= 8.1.1)
283-
activerecord (= 8.1.1)
284-
activestorage (= 8.1.1)
285-
activesupport (= 8.1.1)
274+
rails (8.1.2)
275+
actioncable (= 8.1.2)
276+
actionmailbox (= 8.1.2)
277+
actionmailer (= 8.1.2)
278+
actionpack (= 8.1.2)
279+
actiontext (= 8.1.2)
280+
actionview (= 8.1.2)
281+
activejob (= 8.1.2)
282+
activemodel (= 8.1.2)
283+
activerecord (= 8.1.2)
284+
activestorage (= 8.1.2)
285+
activesupport (= 8.1.2)
286286
bundler (>= 1.15.0)
287-
railties (= 8.1.1)
287+
railties (= 8.1.2)
288288
rails-dom-testing (2.3.0)
289289
activesupport (>= 5.0.0)
290290
minitest
291291
nokogiri (>= 1.6)
292292
rails-html-sanitizer (1.6.2)
293293
loofah (~> 2.21)
294294
nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
295-
railties (8.1.1)
296-
actionpack (= 8.1.1)
297-
activesupport (= 8.1.1)
295+
railties (8.1.2)
296+
actionpack (= 8.1.2)
297+
activesupport (= 8.1.2)
298298
irb (~> 1.13)
299299
rackup (>= 1.0.0)
300300
rake (>= 12.2)
@@ -450,7 +450,7 @@ DEPENDENCIES
450450
minitest-reporters
451451
mutex_m
452452
nokogiri
453-
rails (~> 8.1.0)
453+
rails (~> 8.1.2)
454454
rake
455455
rubocop-rspec
456456
rubocop-shopify

0 commit comments

Comments
 (0)