Merge pull request #917 from Shopify/miaz/allow-names-on-preset-blocks

Allow Names on Preset Blocks

Author: miazbikowski

schemas/theme/preset_blocks.json

@@ -16,6 +16,7 @@
         "properties": {
           "static": true,
           "type": true,
+          "name": true,
           "settings": true,
           "blocks": {
             "$ref": "#/definitions/blocksArray"
@@ -52,6 +53,7 @@
         "properties": {
           "static": true,
           "type": true,
+          "name": true,
           "settings": true,
           "blocks": {
             "$ref": "#/definitions/blocksHash"
@@ -72,6 +74,10 @@
           "type": "string",
           "description": "The block type."
         },
+        "name": {
+          "type": "string",
+          "description": "The block name."
+        },
         "settings": {
           "$ref": "./default_setting_values.json"
         },

tests/fixtures/section-nested-blocks.json

@@ -9,7 +9,7 @@
           "type": "group",
           "blocks": [
             { "type": "text", "settings": { "text": "Hello" } },
-            { "type": "header", "settings": { "text": "World" } }
+            { "type": "header", "name": "Header", "settings": { "text": "World" } }
           ]
         }
       ]

tests/fixtures/section-schema-preset-blocks-as-hash.json

@@ -14,6 +14,7 @@
         "blocks": {
           "exampleBlock": {
             "type": "text",
+            "name": "Example Block",
             "settings": {}
           },
           "exampleBlock2": {

tests/fixtures/theme-block-basics.json

@@ -24,9 +24,17 @@
       "blocks": [
         {
           "type": "thing",
+          "name": "The Thing",
           "settings": {
             "some-setting": "some-value"
-          }
+          },
+          "blocks": [
+            {
+              "type": "text",
+              "name": "Nested Text Block",
+              "settings": {}
+            }
+          ]
         },
         {
           "type": "button",

tests/fixtures/theme-block-presets-as-hash.json

@@ -27,13 +27,15 @@
         },
         "some-other-block-id": {
           "type": "image",
+          "name": "Image Block",
           "static": true,
           "settings": {
             "some-setting": "some-value"
           },
           "blocks": {
             "nested-block-id": {
-              "type": "text"
+              "type": "text",
+              "name": "Nested Text Block"
             }
           },
           "block_order": ["nested-block-id"]