Merge pull request #857 from Shopify/allow-recommendations-in-blocks

Allow recommendations in blocks

Author: graygilmore

.changeset/slimy-stingrays-smile.md

@@ -0,0 +1,6 @@
+---
+'@shopify/theme-check-common': minor
+'@shopify/theme-language-server-common': minor
+---
+
+Allow `recommendations` as a global variable in `blocks/`

packages/theme-check-common/src/checks/undefined-object/index.ts

@@ -191,7 +191,7 @@ function getContextualObjects(relativePath: string): string[] {
   }
 
   if (relativePath.startsWith('blocks/')) {
-    return ['app', 'section', 'block'];
+    return ['app', 'section', 'recommendations', 'block'];
   }
 
   if (relativePath.startsWith('snippets/')) {

packages/theme-language-server-common/src/TypeSystem.ts

@@ -352,7 +352,7 @@ function getContextualEntries(uri: string): string[] {
     return ['section', 'predictive_search', 'recommendations', 'comment'];
   }
   if (BLOCK_FILE_REGEX.test(normalizedUri)) {
-    return ['app', 'section', 'block'];
+    return ['app', 'section', 'recommendations', 'block'];
   }
   if (SNIPPET_FILE_REGEX.test(normalizedUri)) {
     return ['app'];