Skip to content

Liquid inside {% schema %} should not be visited by theme-check. #685

Open
@charlespwd

Description

I think this is somehow related. But since theme blocks are introduced (I think) we can now connect a block value as a default. For instance, inside a section, I have this block:

"blocks": [
    {
      "type": "collection",
      "name": "t:sections.featured_collections.blocks.collection.name",
      "settings": [
        {
          "type": "collection",
          "id": "collection",
          "label": "t:sections.featured_collections.blocks.collection.collection"
        },
        {
          "type": "text",
          "id": "title",
          "label": "t:global.text.title",
          "default": "{{ block.settings.collection.title }}"
        }
  }
]

This is convenient and allow to automatically connect the title with the collection's title of the block.

Theme check report does not currently allow that though:

Image

I am not sure if this is expected @charlespwd

Originally posted by @bakura10 in #624

This is a raw tag that considers liquid differently.

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions