Skip to content

Add config exceptions to Remote Asset check #410

Open
@eloyesp

Description

Is your feature request related to a problem? Please describe.

There are valid exceptions for the single CDN domain that might repeat a lot, and it would be nice to document those on the config file, my personal example now is with polyfill.io that does some magic not available on shopify CDN and is not beauty to add exceptions comments on each place. Other example would be a shop that choose to use Cloudinary across the theme, it is clearly better if the config file could make clear what remotes are "valid" for the store.

Describe the solution you'd like

RemoteAsset:
  additional_remotes:
    - polyfill.io

Describe alternatives you've considered

Using disable comments solves the issue when most violations can be made on the same file, but it adds too much noise when violations are expected on many files.

Additional context

I've been reading the implementation of the check, and it seems that adding this feature seems to be pretty straightforward.

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions