Skip to content

Theme check needs to verify settings values #749

Open
@aswamy

Description

@aswamy

Is your feature request related to a problem? Please describe.
Theme check for preset/default setting values and preset/default block setting values do not verify if the setting type is matched

Describe the solution you'd like
When we declare settings in the schema and provide a default value in the setting that doesn't match it's type it will throw an error (as expected). But when you try to do the same with settings within presets.[].settings, default.settings, presets.[].blocks.[].settings, or default.blocks.[].settings, it ignores the type.

Image

Describe alternatives you've considered

  • This might get more complicated if liquid variables are embedded or complex types are used (e.g. color), but seems like it's something that will make typing settings easier

Checklist

  • I have checked and made sure that the proposal adheres to this plugin's principles

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions