Skip to content

Theme Check should not warn users about https://unpkg.com/@shopify/theme-hot-reload #876

Open
@karreiro

Description

@karreiro

Describe the bug

This script is used for infrastructure purposes and some developers may commit them like this:

{% if request.design_mode %}
  <script
    id="hot-reload-client"
    src="https://unpkg.com/@shopify/theme-hot-reload"
    defer
  ></script>
{% endif %}

Image

Expected behaviour

The warning above shouldn't happen.

Actual behaviour

The warning above happens.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions