From da1d82ceb85f5b58641df0fd5135ba603c4e080f Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Mon, 17 Mar 2025 14:13:47 +0100 Subject: [PATCH 1/4] Allow recommendations in blocks --- .../theme-check-common/src/checks/undefined-object/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/theme-check-common/src/checks/undefined-object/index.ts b/packages/theme-check-common/src/checks/undefined-object/index.ts index 070bf311a..47487e0bf 100644 --- a/packages/theme-check-common/src/checks/undefined-object/index.ts +++ b/packages/theme-check-common/src/checks/undefined-object/index.ts @@ -191,7 +191,7 @@ function getContextualObjects(relativePath: string): string[] { } if (relativePath.startsWith('blocks/')) { - return ['app', 'section', 'block']; + return ['app', 'section', 'recommendations', 'block']; } if (relativePath.startsWith('snippets/')) { From 6268e838124441efe7b95e2dbce714edc6c9afae Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Mon, 17 Mar 2025 14:14:17 +0100 Subject: [PATCH 2/4] Add changeset --- .changeset/slimy-stingrays-smile.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/slimy-stingrays-smile.md diff --git a/.changeset/slimy-stingrays-smile.md b/.changeset/slimy-stingrays-smile.md new file mode 100644 index 000000000..23def32d7 --- /dev/null +++ b/.changeset/slimy-stingrays-smile.md @@ -0,0 +1,5 @@ +--- +'@shopify/theme-check-common': minor +--- + +Allow `recommendations` as a global variable in `blocks/` From d7ca86066fb5bb0bdef8220710fa86149693196a Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Mon, 17 Mar 2025 14:17:09 +0100 Subject: [PATCH 3/4] Also add it to the LSP --- packages/theme-language-server-common/src/TypeSystem.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/theme-language-server-common/src/TypeSystem.ts b/packages/theme-language-server-common/src/TypeSystem.ts index 55456e55a..aa026f1b7 100644 --- a/packages/theme-language-server-common/src/TypeSystem.ts +++ b/packages/theme-language-server-common/src/TypeSystem.ts @@ -352,7 +352,7 @@ function getContextualEntries(uri: string): string[] { return ['section', 'predictive_search', 'recommendations', 'comment']; } if (BLOCK_FILE_REGEX.test(normalizedUri)) { - return ['app', 'section', 'block']; + return ['app', 'section', 'recommendations', 'block']; } if (SNIPPET_FILE_REGEX.test(normalizedUri)) { return ['app']; From 0fb231cc3f3f87e8ceefdb17521d2fb7a88b4798 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Mon, 17 Mar 2025 14:17:36 +0100 Subject: [PATCH 4/4] Tweak changeset --- .changeset/slimy-stingrays-smile.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.changeset/slimy-stingrays-smile.md b/.changeset/slimy-stingrays-smile.md index 23def32d7..63dc62c59 100644 --- a/.changeset/slimy-stingrays-smile.md +++ b/.changeset/slimy-stingrays-smile.md @@ -1,5 +1,6 @@ --- '@shopify/theme-check-common': minor +'@shopify/theme-language-server-common': minor --- Allow `recommendations` as a global variable in `blocks/`