Skip to content

panic: runtime error: slice bounds out of range [808:773] #541

Open
@cbeuw

Description

@cbeuw

This panic happens when using the slicer toxic:

panic: runtime error: slice bounds out of range [808:773]

goroutine 114 [running]:
github.com/Shopify/toxiproxy/v2/toxics.(*SlicerToxic).Pipe(0x1400020c0f0, 0x1400021e480)
	github.com/Shopify/toxiproxy/v2/toxics/slicer.go:65 +0x320
github.com/Shopify/toxiproxy/v2/toxics.(*ToxicStub).Run(0x1400021e480, 0x14000210d20)
	github.com/Shopify/toxiproxy/v2/toxics/toxic.go:86 +0xb8
created by github.com/Shopify/toxiproxy/v2.(*ToxicLink).Start in goroutine 58
	github.com/Shopify/toxiproxy/v2/link.go:109 +0x2c8

The bug is here:

if t.SizeVariation > 0 {
mid += rand.Intn(t.SizeVariation*2) - t.SizeVariation
}

rand.Intn can return a number in [0, SizeVariation*2), so it can be less than SizeVariation, resulting a negative RHS and a mid less than start

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions