Update API and add observables

Author: jonathanhamel4

.changeset/wet-cycles-punch.md

@@ -0,0 +1,5 @@
+---
+'@shopify/ui-extensions': minor
+---
+
+Added subscribable discounts api. Update the type for `data.id` to string to fix a previously incorrect type.

packages/ui-extensions/src/shared.ts

@@ -952,3 +952,19 @@ export interface ReadonlySignalLike<T> {
    */
   subscribe(fn: (value: T) => void): () => void;
 }
+
+type Result<T> =
+  | {success: true; value: T}
+  | {success: false; errors: ValidationError[]};
+
+interface ValidationError {
+  type: 'error';
+  message: string;
+  code: string;
+  issues?: {
+    message: string;
+    path: string[];
+  }[];
+}
+
+export type UpdateSignalFunction<T> = (value: T) => Result<T>;

packages/ui-extensions/src/surfaces/admin/api/discount-function-settings/discount-function-settings.ts

@@ -2,7 +2,10 @@ import type {BlockExtensionApi} from '../block/block';
 import type {ExtensionTarget as AnyExtensionTarget} from '../../extension-targets';
 
 import {ApplyMetafieldChange} from './metafields';
-import {DiscountFunctionSettingsData} from './launch-options';
+import {
+  DiscountFunctionSettingsData,
+  SubscribableDiscountFields,
+} from './launch-options';
 
 export interface DiscountFunctionSettingsApi<
   ExtensionTarget extends AnyExtensionTarget,
@@ -12,4 +15,5 @@ export interface DiscountFunctionSettingsApi<
    */
   applyMetafieldChange: ApplyMetafieldChange;
   data: DiscountFunctionSettingsData;
+  discounts: SubscribableDiscountFields;
 }

packages/ui-extensions/src/surfaces/admin/api/discount-function-settings/launch-options.ts

@@ -1,3 +1,8 @@
+import type {
+  ReadonlySignalLike,
+  UpdateSignalFunction,
+} from '../../../../shared';
+
 interface Metafield {
   description?: string;
   id: string;
@@ -7,23 +12,26 @@ interface Metafield {
   type: string;
 }
 
-export enum DiscountClass {
-  Product = 'PRODUCT',
-  Order = 'ORDER',
-  Shipping = 'SHIPPING',
-}
+type DiscountClass = 'product' | 'order' | 'shipping';
 
-interface Discount {
-  /**
-   * the discount's gid
-   */
-  id: string;
-}
+type DiscountMethod = 'automatic' | 'code';
+
+type PurchaseType = 'one_time_purchase' | 'subscription' | 'both';
 
 /**
  * The object that exposes the validation with its settings.
  */
 export interface DiscountFunctionSettingsData {
-  id: Discount;
+  id: string;
   metafields: Metafield[];
 }
+
+export interface SubscribableDiscountFields {
+  discountClasses: ReadonlySignalLike<DiscountClass[]>;
+  updateDiscountClasses: UpdateSignalFunction<DiscountClass[]>;
+  discountMethod: ReadonlySignalLike<DiscountMethod>;
+  purchaseType: ReadonlySignalLike<PurchaseType>;
+  updatePurchaseType: UpdateSignalFunction<PurchaseType>;
+  recurringCycleLimit: ReadonlySignalLike<number | null | undefined>;
+  updateRecurringCycleLimit: UpdateSignalFunction<number | null | undefined>;
+}