Skip to content

Conversation

@james-a-c
Copy link

@james-a-c james-a-c commented Dec 17, 2025

Background

Part of https://github.com/shop/issues-checkout/issues/9641

Changes to the Delivery section through the delivery redesign experiment have created 2 locations for the pickup-location-option-item-render-after target to render extensions, one of them being in a modal. We need a way to inform the extensions that are being rendered in this target that they are currently in a modal (or not).

Screenshots

Inline

Screenshot 2025-12-19 at 11 31 18 AM

In modal

Screenshot 2025-12-19 at 11 27 40 AM

Solution

Extend the same pattern we use for shipping-option-item-render-after by exposing the renderMode object on PickupLocationItemApi

PickupLocationItemApi
{
  isTargetSelected,
  target,
  renderMode: {
    overlay: false
  }
}

🎩

  • ...

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Copy link
Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@james-a-c james-a-c marked this pull request as ready for review December 17, 2025 20:02
@github-actions

This comment has been minimized.

@james-a-c james-a-c force-pushed the add-pickup-location-item-render-mode branch from 12394f5 to 13089af Compare December 17, 2025 20:04
@james-a-c
Copy link
Author

/snapit

@james-a-c james-a-c marked this pull request as draft December 17, 2025 20:47
@james-a-c james-a-c force-pushed the add-pickup-location-item-render-mode branch 2 times, most recently from 35f30b6 to 66ed2db Compare December 19, 2025 15:33
@james-a-c james-a-c changed the title add rendermode field to pickup location item api Add renderMode object to PickupLocationItem Dec 19, 2025
@james-a-c james-a-c changed the title Add renderMode object to PickupLocationItem Add renderMode object to PickupLocationItemApi Dec 19, 2025
@dnagoda
Copy link
Contributor

dnagoda commented Dec 19, 2025

/snapit

1 similar comment
@dnagoda
Copy link
Contributor

dnagoda commented Dec 19, 2025

/snapit

@james-a-c james-a-c force-pushed the add-pickup-location-item-render-mode branch from 66ed2db to 3248efc Compare December 19, 2025 21:35
@james-a-c james-a-c marked this pull request as ready for review December 19, 2025 21:37
Copy link
Author

/snapit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants