Merge pull request stratum-mining#74 from Shourya742/2025-11-06-remove-unwanted-error-variants

Remove unwanted error variants in JDC

Author: plebhash

miner-apps/jd-client/src/lib/error.rs

@@ -45,8 +45,6 @@ pub enum ChannelSv2Error {
 
 #[derive(Debug)]
 pub enum JDCError {
-    #[allow(dead_code)]
-    VecToSlice32(Vec<u8>),
     /// Errors on bad CLI argument input.
     BadCliArgs,
     /// Errors on bad `config` TOML deserialize.
@@ -61,45 +59,62 @@ pub enum JDCError {
     Io(std::io::Error),
     /// Errors on bad `String` to `int` conversion.
     ParseInt(std::num::ParseIntError),
-    #[allow(dead_code)]
-    SubprotocolMining(String),
-    // Locking Errors
-    PoisonLock,
-    TokioChannelErrorRecv(tokio::sync::broadcast::error::RecvError),
-    Infallible(std::convert::Infallible),
     Parser(ParserError),
     /// Channel receiver error
     ChannelErrorReceiver(async_channel::RecvError),
     /// Channel sender error
     ChannelErrorSender,
     /// Broadcast channel receiver error
     BroadcastChannelErrorReceiver(broadcast::error::RecvError),
+    /// Shutdown
     Shutdown,
+    /// Network helpers error
     NetworkHelpersError(network_helpers::Error),
+    /// Unexpected message
     UnexpectedMessage(u8),
+    /// Invalid user identity
     InvalidUserIdentity(String),
+    /// Bitcoin encode error
     BitcoinEncodeError(bitcoin::consensus::encode::Error),
+    /// Invalid socket address
     InvalidSocketAddress(String),
+    /// Timeout error
     Timeout,
+    /// Declared job corresponding to request Id not found.
     LastDeclareJobNotFound(RequestId),
+    /// No active job with job id
     ActiveJobNotFound(JobId),
+    /// No active token
     TokenNotFound,
+    /// Template not found with template ID
     TemplateNotFound(TemplateId),
+    /// Downstream not found with downstream ID
     DownstreamNotFound(DownstreamId),
-    DownstreamIdNotFound,
+    /// Future template not present
     FutureTemplateNotPresent,
+    /// Last new prevhash not found
     LastNewPrevhashNotFound,
+    /// Vardiff not found
     VardiffNotFound(VardiffKey),
+    /// Tx data error
     TxDataError,
+    /// Frame conversion error
     FrameConversionError,
+    /// Failed to create custom Job
     FailedToCreateCustomJob,
+    /// Allocate Mining job token coinbase output error
     AllocateMiningJobTokenSuccessCoinbaseOutputsError,
+    /// Channel manager has bad coinbase outputs.
     ChannelManagerHasBadCoinbaseOutputs,
+    /// Declared job has bad coinbase outputs.
     DeclaredJobHasBadCoinbaseOutputs,
+    /// Extranonce size is too large
     ExtranonceSizeTooLarge,
+    /// Could not create group channel
     FailedToCreateGroupChannel(GroupChannelError),
     ///Channel Errors
     ChannelSv2(ChannelSv2Error),
+    /// Extranonce prefix error
     ExtranoncePrefixFactoryError(ExtendedExtranonceError),
 }
 
@@ -116,12 +131,7 @@ impl fmt::Display for JDCError {
             FramingSv2(ref e) => write!(f, "Framing SV2 error: `{e:?}`"),
             Io(ref e) => write!(f, "I/O error: `{e:?}"),
             ParseInt(ref e) => write!(f, "Bad convert from `String` to `int`: `{e:?}`"),
-            SubprotocolMining(ref e) => write!(f, "Subprotocol Mining Error: `{e:?}`"),
-            PoisonLock => write!(f, "Poison Lock error"),
             ChannelErrorReceiver(ref e) => write!(f, "Channel receive error: `{e:?}`"),
-            TokioChannelErrorRecv(ref e) => write!(f, "Channel receive error: `{e:?}`"),
-            VecToSlice32(ref e) => write!(f, "Standard Error: `{e:?}`"),
-            Infallible(ref e) => write!(f, "Infallible Error:`{e:?}`"),
             Parser(ref e) => write!(f, "Parser error: `{e:?}`"),
             BroadcastChannelErrorReceiver(ref e) => {
                 write!(f, "Broadcast channel receive error: {e:?}")
@@ -152,9 +162,6 @@ impl fmt::Display for JDCError {
                     "Downstream not found with downstream_id: {downstream_id}"
                 )
             }
-            DownstreamIdNotFound => {
-                write!(f, "Downstream id not found")
-            }
             FutureTemplateNotPresent => {
                 write!(f, "Future template not present")
             }
@@ -212,7 +219,6 @@ impl JDCError {
                 | JDCError::TokenNotFound
                 | JDCError::TemplateNotFound(_)
                 | JDCError::DownstreamNotFound(_)
-                | JDCError::DownstreamIdNotFound
                 | JDCError::VardiffNotFound(_)
                 | JDCError::TxDataError
                 | JDCError::FrameConversionError
@@ -280,12 +286,6 @@ impl From<async_channel::RecvError> for JDCError {
     }
 }
 
-impl From<tokio::sync::broadcast::error::RecvError> for JDCError {
-    fn from(e: tokio::sync::broadcast::error::RecvError) -> Self {
-        JDCError::TokioChannelErrorRecv(e)
-    }
-}
-
 impl From<network_helpers::Error> for JDCError {
     fn from(value: network_helpers::Error) -> Self {
         JDCError::NetworkHelpersError(value)