setState running twice

[stygianlgdonic]

Every time i setState, it runs twice. How can i fix that?

[Shrugsy]

Hi @stygianlgdonic, can you please provide some steps to reproduce this? If you can reproduce it in codeSandbox I could investigate it.

Trying a barebones example, I couldn't see any behaviour occurring where anything runs twice unexpectedly: https://codesandbox.io/s/happy-allen-64qxm?file=/src/App.tsx

[stygianlgdonic]

Ok i just replaced the useImmerState hook with https://github.com/mweststrate/use-immer
and it's not running twice on that particular location

[stygianlgdonic]

Hey @Shrugsy i was looking around for solutions and since i am using app in StrictMode
i found this: https://stackoverflow.com/a/62140933
could this be the reason?

[stygianlgdonic]

If you could do something like, if setState is called with same values, it shouldn't be pushed in the history array?

[Shrugsy]

Hi @stygianlgdonic. It is possibly related, but I can't know for sure without being able to replicate it and investigate it thoroughly.
Strict mode should call the setState call twice, but I would also expect that the console.log is suppressed during the second pass.

I've pushed a new version (3.0.0) which no longer changes the history array when setState returns the same state. It is fundamentally unrelated to the behaviour you describe with setState being called twice, but I believe it is better behaviour regardless.

[stygianlgdonic]

@Shrugsy Thanks a lot, I'll work on history. Indeed this is a better behavior. Thanks again