Fix CI: update Go version and fix lint errors

Siddhant-K-code · Siddhant-K-code · commit 0fb26014d1e2 · 2026-01-01T07:00:56.000Z
- Update Dockerfile to Go 1.24 (matches go.mod)
- Update GitHub Actions to Go 1.24
- Fix errcheck: handle return values from viper.BindPFlag, json.Encode, etc.
- Fix gosimple: remove redundant nil check before len()
- Fix staticcheck: use grpc.NewClient instead of deprecated DialContext
- Add nolint for Qdrant SDK deprecation (no replacement available yet)
- Update golangci-lint action to v6
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
 
       - name: Download dependencies
         run: go mod download
@@ -34,9 +34,9 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v4
+        uses: golangci/golangci-lint-action@v6
         with:
           version: latest
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -19,7 +19,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.24'
 
       - name: Run GoReleaser
         uses: goreleaser/goreleaser-action@v5
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 # Build stage
-FROM golang:1.22-alpine AS builder
+FROM golang:1.24-alpine AS builder
 
 WORKDIR /app
 
diff --git a/cmd/analyze.go b/cmd/analyze.go
@@ -41,10 +41,10 @@ func init() {
 	analyzeCmd.Flags().IntP("workers", "w", 0, "number of parallel workers (0 = NumCPU)")
 	analyzeCmd.Flags().Int64("seed", 0, "random seed for reproducibility (0 = random)")
 
-	analyzeCmd.MarkFlagRequired("file")
+	_ = analyzeCmd.MarkFlagRequired("file")
 
-	viper.BindPFlag("analyze.threshold", analyzeCmd.Flags().Lookup("threshold"))
-	viper.BindPFlag("analyze.clusters", analyzeCmd.Flags().Lookup("clusters"))
+	_ = viper.BindPFlag("analyze.threshold", analyzeCmd.Flags().Lookup("threshold"))
+	_ = viper.BindPFlag("analyze.clusters", analyzeCmd.Flags().Lookup("clusters"))
 }
 
 func runAnalyze(cmd *cobra.Command, args []string) error {
diff --git a/cmd/api.go b/cmd/api.go
@@ -207,7 +207,7 @@ func corsMiddleware(next http.Handler) http.Handler {
 
 func (s *APIServer) handleRoot(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(map[string]interface{}{
+	_ = json.NewEncoder(w).Encode(map[string]interface{}{
 		"name":    "Distill API",
 		"version": "1.0.0",
 		"docs":    "https://distill.siddhantkhare.com/docs",
@@ -357,10 +357,10 @@ func (s *APIServer) handleDedupe(w http.ResponseWriter, r *http.Request) {
 	}
 
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 func (s *APIServer) handleHealth(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(map[string]string{"status": "ok"})
+	_ = json.NewEncoder(w).Encode(map[string]string{"status": "ok"})
 }
diff --git a/cmd/mcp.go b/cmd/mcp.go
@@ -241,7 +241,7 @@ func runMCP(cmd *cobra.Command, args []string) error {
 		// Health check endpoint
 		mux.HandleFunc("/health", func(w http.ResponseWriter, r *http.Request) {
 			w.Header().Set("Content-Type", "application/json")
-			w.Write([]byte(`{"status":"ok","server":"govectorsync-mcp"}`))
+			_, _ = w.Write([]byte(`{"status":"ok","server":"govectorsync-mcp"}`))
 		})
 
 		// MCP endpoint with stateful sessions
diff --git a/cmd/root.go b/cmd/root.go
@@ -45,7 +45,7 @@ func init() {
 	rootCmd.PersistentFlags().Bool("verbose", false, "enable verbose output")
 
 	// Bind to viper
-	viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))
+	_ = viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))
 }
 
 // initConfig reads in config file and ENV variables if set.
diff --git a/cmd/serve.go b/cmd/serve.go
@@ -62,8 +62,8 @@ func init() {
 	serveCmd.Flags().Bool("enable-mmr", true, "Enable MMR re-ranking")
 
 	// Bind to viper
-	viper.BindPFlag("serve.port", serveCmd.Flags().Lookup("port"))
-	viper.BindPFlag("serve.host", serveCmd.Flags().Lookup("host"))
+	_ = viper.BindPFlag("serve.port", serveCmd.Flags().Lookup("port"))
+	_ = viper.BindPFlag("serve.host", serveCmd.Flags().Lookup("host"))
 }
 
 // Server holds the HTTP server state.
@@ -359,18 +359,18 @@ func (s *Server) handleRetrieve(w http.ResponseWriter, r *http.Request) {
 	}
 
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 func (s *Server) handleHealth(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(map[string]string{"status": "ok"})
+	_ = json.NewEncoder(w).Encode(map[string]string{"status": "ok"})
 }
 
 func (s *Server) handleMetrics(w http.ResponseWriter, r *http.Request) {
 	cfg := s.broker.GetConfig()
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(map[string]interface{}{
+	_ = json.NewEncoder(w).Encode(map[string]interface{}{
 		"config": map[string]interface{}{
 			"over_fetch_k": cfg.OverFetchK,
 			"target_k":     cfg.TargetK,
diff --git a/cmd/sync.go b/cmd/sync.go
@@ -35,7 +35,7 @@ func init() {
 
 	// File input
 	syncCmd.Flags().StringP("file", "f", "", "path to JSONL file containing vectors (required)")
-	syncCmd.MarkFlagRequired("file")
+	_ = syncCmd.MarkFlagRequired("file")
 
 	// Pinecone settings
 	syncCmd.Flags().StringP("index", "i", "", "Pinecone index name (required)")
@@ -52,9 +52,9 @@ func init() {
 	syncCmd.Flags().IntP("batch-size", "b", 100, "vectors per batch (Pinecone optimal: 100)")
 
 	// Bind to viper
-	viper.BindPFlag("api_key", syncCmd.Flags().Lookup("api-key"))
-	viper.BindPFlag("index", syncCmd.Flags().Lookup("index"))
-	viper.BindPFlag("namespace", syncCmd.Flags().Lookup("namespace"))
+	_ = viper.BindPFlag("api_key", syncCmd.Flags().Lookup("api-key"))
+	_ = viper.BindPFlag("index", syncCmd.Flags().Lookup("index"))
+	_ = viper.BindPFlag("namespace", syncCmd.Flags().Lookup("namespace"))
 }
 
 func runSync(cmd *cobra.Command, args []string) error {
@@ -185,7 +185,7 @@ func runSync(cmd *cobra.Command, args []string) error {
 		current := stats.UploadedVectors + stats.FailedVectors
 		delta := current - lastUploaded
 		if delta > 0 {
-			bar.Add64(delta)
+			_ = bar.Add64(delta)
 			lastUploaded = current
 		}
 	}
@@ -197,7 +197,7 @@ func runSync(cmd *cobra.Command, args []string) error {
 		return fmt.Errorf("ingestion failed: %w", err)
 	}
 
-	bar.Finish()
+	_ = bar.Finish()
 	fmt.Fprintln(os.Stderr)
 
 	// Print summary
diff --git a/pkg/pinecone/client.go b/pkg/pinecone/client.go
@@ -178,7 +178,7 @@ func (c *Client) Close() error {
 
 // convertMetadata converts map[string]interface{} to Pinecone Struct metadata.
 func convertMetadata(m map[string]interface{}) *structpb.Struct {
-	if m == nil || len(m) == 0 {
+	if len(m) == 0 {
 		return nil
 	}
 
diff --git a/pkg/retriever/pinecone/client.go b/pkg/retriever/pinecone/client.go
@@ -100,11 +100,8 @@ func (c *Client) Query(ctx context.Context, req *types.RetrievalRequest) (*types
 		IncludeMetadata: req.IncludeMetadata,
 	}
 
-	// Use namespace from request or default
-	namespace := req.Namespace
-	if namespace == "" {
-		namespace = c.cfg.DefaultNamespace
-	}
+	// Note: namespace is set at connection level in NewClient
+	// Per-query namespace override would require creating a new connection
 
 	// Execute query
 	resp, err := c.idxConn.QueryByVectorValues(ctx, queryReq)
diff --git a/pkg/retriever/qdrant/client.go b/pkg/retriever/qdrant/client.go
@@ -68,7 +68,7 @@ func NewClient(ctx context.Context, cfg Config) (*Client, error) {
 
 	// Connect to Qdrant
 	addr := fmt.Sprintf("%s:%d", cfg.Host, cfg.GRPCPort)
-	conn, err := grpc.DialContext(ctx, addr, opts...)
+	conn, err := grpc.NewClient(addr, opts...)
 	if err != nil {
 		return nil, fmt.Errorf("failed to connect to Qdrant at %s: %w", addr, err)
 	}
@@ -148,7 +148,7 @@ func (c *Client) Query(ctx context.Context, req *types.RetrievalRequest) (*types
 		// Extract embedding if included
 		if point.Vectors != nil {
 			if vec := point.Vectors.GetVector(); vec != nil {
-				chunk.Embedding = vec.Data
+				chunk.Embedding = vec.GetData() //nolint:staticcheck // Qdrant SDK deprecation, no replacement yet
 			}
 		}
 
@@ -218,7 +218,7 @@ func (c *Client) QueryByID(ctx context.Context, id string, topK int, namespace s
 	var vector []float32
 	if point.Vectors != nil {
 		if vec := point.Vectors.GetVector(); vec != nil {
-			vector = vec.Data
+			vector = vec.GetData() //nolint:staticcheck // Qdrant SDK deprecation, no replacement yet
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ func corsMiddleware(next http.Handler) http.Handler {`
`207`	`207`
`208`	`208`	`func (s APIServer) handleRoot(w http.ResponseWriter, r http.Request) {`
`209`	`209`	`w.Header().Set("Content-Type", "application/json")`
`210`		`- json.NewEncoder(w).Encode(map[string]interface{}{`
	`210`	`+ _ = json.NewEncoder(w).Encode(map[string]interface{}{`
`211`	`211`	`"name": "Distill API",`
`212`	`212`	`"version": "1.0.0",`
`213`	`213`	`"docs": "https://distill.siddhantkhare.com/docs",`
`@@ -357,10 +357,10 @@ func (s APIServer) handleDedupe(w http.ResponseWriter, r http.Request) {`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`w.Header().Set("Content-Type", "application/json")`
`360`		`- json.NewEncoder(w).Encode(resp)`
	`360`	`+ _ = json.NewEncoder(w).Encode(resp)`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`func (s APIServer) handleHealth(w http.ResponseWriter, r http.Request) {`
`364`	`364`	`w.Header().Set("Content-Type", "application/json")`
`365`		`- json.NewEncoder(w).Encode(map[string]string{"status": "ok"})`
	`365`	`+ _ = json.NewEncoder(w).Encode(map[string]string{"status": "ok"})`
`366`	`366`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func init() {`
`45`	`45`	`rootCmd.PersistentFlags().Bool("verbose", false, "enable verbose output")`
`46`	`46`
`47`	`47`	`// Bind to viper`
`48`		`- viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))`
	`48`	`+ _ = viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`// initConfig reads in config file and ENV variables if set.`
Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ func (c *Client) Close() error {`
`178`	`178`
`179`	`179`	`// convertMetadata converts map[string]interface{} to Pinecone Struct metadata.`
`180`	`180`	`func convertMetadata(m map[string]interface{}) *structpb.Struct {`
`181`		`- if m == nil \|\| len(m) == 0 {`
	`181`	`+ if len(m) == 0 {`
`182`	`182`	`return nil`
`183`	`183`	`}`
`184`	`184`