Skip to content

Commit a2ad2fa

Browse files
Fix errcheck: handle Close() return values in defer
Wrap all defer Close() calls with anonymous functions to properly ignore the return value and satisfy errcheck linter.
1 parent 6c6e886 commit a2ad2fa

7 files changed

Lines changed: 10 additions & 10 deletions

File tree

cmd/analyze.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ func loadVectorsFromFile(filePath string) ([]types.Vector, error) {
122122
if err != nil {
123123
return nil, err
124124
}
125-
defer file.Close()
125+
defer func() { _ = file.Close() }()
126126

127127
var vectors []types.Vector
128128
scanner := bufio.NewScanner(file)

cmd/mcp.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,15 @@ func runMCP(cmd *cobra.Command, args []string) error {
196196
if err != nil {
197197
return fmt.Errorf("failed to create retriever: %w", err)
198198
}
199-
defer ret.Close()
199+
defer func() { _ = ret.Close() }()
200200

201201
// Create broker with retriever
202202
if mcpSrv.embedder != nil {
203203
mcpSrv.broker = contextlab.NewBrokerWithEmbedder(ret, mcpSrv.embedder, brokerCfg)
204204
} else {
205205
mcpSrv.broker = contextlab.NewBroker(ret, brokerCfg)
206206
}
207-
defer mcpSrv.broker.Close()
207+
defer func() { _ = mcpSrv.broker.Close() }()
208208
}
209209

210210
// Create MCP server with capabilities

cmd/query.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ func runQuery(cmd *cobra.Command, args []string) error {
148148
if err != nil {
149149
return fmt.Errorf("failed to create retriever: %w", err)
150150
}
151-
defer ret.Close()
151+
defer func() { _ = ret.Close() }()
152152

153153
// Create embedding provider
154154
embedder, err := openai.NewClient(openai.Config{
@@ -212,7 +212,7 @@ func runQuery(cmd *cobra.Command, args []string) error {
212212
}
213213

214214
broker := contextlab.NewBrokerWithEmbedder(ret, embedder, brokerCfg)
215-
defer broker.Close()
215+
defer func() { _ = broker.Close() }()
216216

217217
req := &types.RetrievalRequest{
218218
QueryEmbedding: embedding,

cmd/serve.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ func runServe(cmd *cobra.Command, args []string) error {
186186
if err != nil {
187187
return fmt.Errorf("failed to create retriever: %w", err)
188188
}
189-
defer ret.Close()
189+
defer func() { _ = ret.Close() }()
190190

191191
// Create embedding provider if OpenAI key is provided
192192
var embedder retriever.EmbeddingProvider
@@ -218,7 +218,7 @@ func runServe(cmd *cobra.Command, args []string) error {
218218
} else {
219219
broker = contextlab.NewBroker(ret, brokerCfg)
220220
}
221-
defer broker.Close()
221+
defer func() { _ = broker.Close() }()
222222

223223
// Create server
224224
server := &Server{

cmd/sync.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func runSync(cmd *cobra.Command, args []string) error {
155155
if err != nil {
156156
return fmt.Errorf("failed to connect to Pinecone: %w", err)
157157
}
158-
defer client.Close()
158+
defer func() { _ = client.Close() }()
159159

160160
// Create ingestion pipeline
161161
ingestCfg := ingest.Config{

pkg/embedding/openai/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ func (c *Client) doRequest(ctx context.Context, body []byte) (*embeddingResponse
225225
if err != nil {
226226
return nil, fmt.Errorf("request failed: %w", err)
227227
}
228-
defer resp.Body.Close()
228+
defer func() { _ = resp.Body.Close() }()
229229

230230
respBody, err := io.ReadAll(resp.Body)
231231
if err != nil {

pkg/ingest/pipeline.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func (p *Pipeline) IngestFile(ctx context.Context, filePath string, progress Pro
9999
if err != nil {
100100
return nil, fmt.Errorf("failed to open file: %w", err)
101101
}
102-
defer file.Close()
102+
defer func() { _ = file.Close() }()
103103

104104
return p.IngestReader(ctx, file, progress)
105105
}

0 commit comments

Comments
 (0)