fix(lint): resolve errcheck, unused, and ineffassign violations

- pkg/batch/batch_test.go: check Submit return values, remove unused makeChunks
- cmd/api_pipeline.go: check json.Encoder.Encode return values, fix
  ineffectual assignment in handleBatchResults error path

Co-authored-by: Ona <no-reply@ona.com>

Author: Siddhant-K-code

cmd/api_pipeline.go

@@ -143,7 +143,7 @@ func (a *PipelineAPI) handlePipeline(w http.ResponseWriter, r *http.Request) {
 		Stats:  marshalStats(stats),
 	}
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 // handleBatchSubmit accepts a new batch job.
@@ -170,7 +170,7 @@ func (a *PipelineAPI) handleBatchSubmit(w http.ResponseWriter, r *http.Request)
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusAccepted)
-	json.NewEncoder(w).Encode(BatchSubmitResponse{
+	_ = json.NewEncoder(w).Encode(BatchSubmitResponse{
 		JobID:  job.ID,
 		Status: string(job.Status),
 	})
@@ -221,17 +221,15 @@ func (a *PipelineAPI) handleBatchStatus(w http.ResponseWriter, _ *http.Request,
 		resp.CompletedAt = job.CompletedAt.UTC().Format("2006-01-02T15:04:05Z")
 	}
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 func (a *PipelineAPI) handleBatchResults(w http.ResponseWriter, _ *http.Request, id string) {
 	chunks, stats, err := a.processor.Results(id)
 	if err != nil {
-		code := http.StatusNotFound
+		code := http.StatusConflict
 		if err == batch.ErrJobNotFound {
 			code = http.StatusNotFound
-		} else {
-			code = http.StatusConflict
 		}
 		http.Error(w, err.Error(), code)
 		return
@@ -243,7 +241,7 @@ func (a *PipelineAPI) handleBatchResults(w http.ResponseWriter, _ *http.Request,
 		Stats:  marshalStats(stats),
 	}
 	w.Header().Set("Content-Type", "application/json")
-	json.NewEncoder(w).Encode(resp)
+	_ = json.NewEncoder(w).Encode(resp)
 }
 
 // ── helpers ───────────────────────────────────────────────────────────────────

pkg/batch/batch_test.go

@@ -1,24 +1,14 @@
 package batch
 
 import (
-	"fmt"
 	"testing"
 	"time"
 
 	"github.com/Siddhant-K-code/distill/pkg/pipeline"
 	"github.com/Siddhant-K-code/distill/pkg/types"
 )
 
-func makeChunks(n int) []types.Chunk {
-	chunks := make([]types.Chunk, n)
-	for i := range chunks {
-		chunks[i] = types.Chunk{
-			ID:   fmt.Sprintf("chunk-%d", i),
-			Text: "test chunk content for batch processing",
-		}
-	}
-	return chunks
-}
+
 
 func TestSubmitAndGet(t *testing.T) {
 	p := NewProcessor(Config{Workers: 1, QueueSize: 10, ResultTTL: time.Minute})
@@ -84,8 +74,8 @@ func TestList(t *testing.T) {
 	p := NewProcessor(Config{Workers: 1, QueueSize: 10, ResultTTL: time.Minute})
 	defer p.Stop()
 
-	p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "a", Text: "hello"}}, Options: pipeline.Options{}})
-	p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "b", Text: "world"}}, Options: pipeline.Options{}})
+	_, _ = p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "a", Text: "hello"}}, Options: pipeline.Options{}})
+	_, _ = p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "b", Text: "world"}}, Options: pipeline.Options{}})
 
 	// Wait briefly for processing.
 	time.Sleep(200 * time.Millisecond)
@@ -102,7 +92,7 @@ func TestQueueFull(t *testing.T) {
 	defer p.Stop()
 
 	// Fill the queue.
-	p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "a", Text: "x"}}, Options: pipeline.Options{}})
+	_, _ = p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "a", Text: "x"}}, Options: pipeline.Options{}})
 
 	// This should fail.
 	_, err := p.Submit(SubmitRequest{Chunks: []types.Chunk{{ID: "b", Text: "y"}}, Options: pipeline.Options{}})