fix: revert go directive to 1.24.0 after dependabot bump#75
Merged
Conversation
go.opentelemetry.io/otel v1.43.0 (merged via #46) ran go mod tidy on a Go 1.25 toolchain, which upgraded the go directive in go.mod to 1.25.0. Go 1.25 is not yet released and golangci-lint refuses to lint modules targeting it, breaking CI. Downgrade otel back to v1.40.0 (last version compatible with Go 1.24), revert golang.org/x/sys to v0.40.0, and pin the go directive to 1.24.0. Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dependabot PR (#46) bumped
go.opentelemetry.io/otelto v1.43.0. That version'sgo.modrequires Go 1.25, and when dependabot rango mod tidyon its toolchain it upgraded ourgodirective to1.25.0. Go 1.25 is not yet released, sogolangci-lintrefuses to run against it, breaking the lint CI job.Fix
go.opentelemetry.io/oteland related packages back tov1.40.0(last version compatible with Go 1.24)golang.org/x/systov0.40.0godirective back to1.24.0go mod tidywithGOTOOLCHAIN=go1.24.0to prevent re-upgradeVerification