Tags inheritance seems not to be working with multiple groups

[BenjaminMercier19]

Hi,

Thanks for the great addon, but a difference seems to appeared since my last upgrade. I upgraded to storybook 9 and hence upgraded this addon from 1.0.4 to the latest 2.0.2.
Tags used not to be displayed when there was inheritance from a group (stories or docs inside group), but even if there was a group in a group. This was the expected behavior.
Now that changed and this happen :

• group 1=> show tag
  • child story 1.1 => no tag
  • child story 1.2 => no tag
  • group 1.3 => no tag
    • child story 1.3.1 => show tag
    • child story 1.3.2 => show tag

In my example, 1.3.1 and 1.3.2 should not display tags, am I wrong on this ? This was the behavior before.

FYI, I'm using those versions :

    "storybook": "9.1.2",
    "storybook-addon-tag-badges": "2.0.2",

and I configured the tags with this :

      display: {
        mdx: ['story', 'component'],
        sidebar: [
          {type: 'story', skipInherited: true},
          {type: 'docs', skipInherited: true},
          {type: 'component', skipInherited: true},
          {type: 'group', skipInherited: true},
        ],
        toolbar: ['docs', 'story'],
      },

[Sidnioulz]

Hi @BenjaminMercier19!

Thanks for catching this. I likely need to recursively check if a parent "displays" a tag through its own inheritence instead of just if it shows it directly. Should be easy to fix but I'm a bit busy this month, so it may take a while for me to code the fix.

Note to self: the logic on https://github.com/Sidnioulz/storybook-addon-tag-badges/blob/main/src/useBadgesToDisplay.ts#L72 needs to be replaced with a recursive logic computing all tags that can be considered "displayed" directly or indirectly.

[Sidnioulz]

Hey @BenjaminMercier19

I've set up a bunch of repro cases in the issue-102 branch but could not reproduce the issue you described. Could you please provide me with a reproduction repository?

Thanks