Merge pull request #18 from SiegfriedBz/feature/fix-publisher-reviewer-pool-sync

fix(contracts): sync publisher into reviewer pool after publication is published

## Summary
This PR fixes a state synchronization issue where publishers were not being added to the available reviewer pool after their locked stake was returned upon publication settlement. It ensures that the protocol correctly evaluates a publisher's eligibility for the reviewer pool based on their updated `availableStake`.

## Problem
In the `_settlePublication` logic, the contract successfully returned the locked stake to the publisher when a publication reached the `PUBLISHED` state. However, it was not triggering `_syncReviewerStatus` for the publisher address. 

Consequently, even if the returned stake pushed the publisher’s balance above the required threshold to act as a reviewer, their status in the `availableReviewersPool` remained stale, preventing them from being selected for future reviews until a manual or unrelated state change occurred.

## Solution
- Modified `_settlePublication` to include a call to `_syncReviewerStatus(pub.publisher)` after the stake is unlocked and returned.
- This ensures the `availableReviewersPool` and `isAvailableReviewer` mapping are updated immediately to reflect the publisher's new liquid stake.

## Changes
### Smart Contract
  - Added `_syncReviewerStatus(pub.publisher)` within the settlement branch for successful publications.

### Testing & Verification
- **Updated Existing Tests**: Enhanced current publication tests to include assertions for the `IsAvailableReviewer` event.
- **New Test Case**: `test_PublishPublication_PublisherBecomesAvailableReviewer`
  - Validates that a publisher with zero initial available stake is correctly added to the reviewer pool once their publication stake is returned.
  - Asserted all three parameters of the `IsAvailableReviewer` event to ensure data integrity.

Author: SiegfriedBz

apps/contracts/src/BioVerifyV3.sol

@@ -523,6 +523,7 @@ contract BioVerifyV3 is VRFConsumerBaseV2Plus, ReentrancyGuard {
         if (_newStatus == PublicationStatus.PUBLISHED) {
             // Publisher reward
             _unLockStakeAndReward(pub.publisher, _pubId, true);
+            _syncReviewerStatus(pub.publisher);
         } else if (_newStatus == PublicationStatus.SLASHED) {
             // Publisher Slash
             _unLockStakeAndSlash(pub.publisher, _pubId, true);

apps/contracts/test/09_PublishPublication.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: UNLICENSED
 pragma solidity ^0.8.13;
 
+import {Vm} from "forge-std/Vm.sol";
 import {TestHelpers} from "./01_Helpers.t.sol";
 import {
 
@@ -62,6 +63,7 @@ contract PublishPublicationTest is TestHelpers {
         _expectEmit_MemberLockedStakeOnPubId(publisher, 0, 0);
         _expectEmit_LockedStakeOnPubId(0, remainingLocked);
         _expectEmit_MemberAvailableStake(publisher, publisherStake);
+        _expectEmit_IsAvailableReviewer(publisher, true, 0);
 
         // --- 3. EXPECTATIONS: HONEST REVIEWERS ---
         for (uint256 i = 0; i < honestCount; i++) {
@@ -240,4 +242,53 @@ contract PublishPublicationTest is TestHelpers {
         vm.expectRevert(abi.encodeWithSelector(BioVerify_InvalidPublicationId.selector, nonExistentId));
         bioVerify.publishPublication(nonExistentId, new address[](0), new address[](0), "verdict");
     }
+
+    function test_PublishPublication_PublisherBecomesAvailableReviewer() public {
+        // --- 1. SETUP ---
+        _submitDefaultPub();
+        _fillValidReviewerPool();
+
+        vm.prank(aiAgentAddress);
+        uint256 requestId = bioVerify.pickReviewers(0);
+
+        uint256[] memory words = new uint256[](vrfNumWords);
+        for (uint256 i = 0; i < vrfNumWords; ++i) {
+            words[i] = i;
+        }
+        vrfCoordinatorMock.fulfillRandomWordsWithOverride(requestId, address(bioVerify), words);
+
+        // --- 2. Build all-honest reviewer arrays ---
+        address[] memory honest = new address[](vrfNumWords);
+        for (uint256 i = 0; i < vrfNumWords; i++) {
+            honest[i] = makeAddr(string(abi.encodePacked("reviewer_", i)));
+        }
+        address[] memory negligent = new address[](0);
+
+        // --- 3. EXECUTION ---
+        vm.recordLogs();
+        vm.prank(aiAgentAddress);
+        bioVerify.publishPublication(0, honest, negligent, FAKE_VERDICT_CID);
+
+        // --- 4. ASSERTION ---
+        // Publisher's returned stake (publisherStake) >= reviewerStake,
+        // so _syncReviewerStatus must mark them as available for future review cycles.
+        Vm.Log[] memory entries = vm.getRecordedLogs();
+        bytes32 eventSig = keccak256("IsAvailableReviewer(address,bool,uint256)");
+
+        bool foundPublisherEvent = false;
+        for (uint256 i = 0; i < entries.length; i++) {
+            if (entries[i].topics[0] != eventSig) continue;
+
+            address member = address(uint160(uint256(entries[i].topics[1])));
+            if (member == publisher) {
+                (bool isAvailable, uint256 newActiveReviews) = abi.decode(entries[i].data, (bool, uint256));
+                assertEq(member, publisher, "Event reviewer must be publisher");
+                assertTrue(isAvailable, "Publisher must become available reviewer after publication");
+                assertEq(newActiveReviews, 0, "Publisher must have 0 active reviews");
+                foundPublisherEvent = true;
+                break;
+            }
+        }
+        assertTrue(foundPublisherEvent, "IsAvailableReviewer event must be emitted for publisher");
+    }
 }

apps/fe/tsconfig.json

@@ -19,7 +19,6 @@
 				"name": "next"
 			}
 		],
-		"baseUrl": ".",
 		"paths": {
 			"@/*": ["./*"],
 			"@packages/*": ["../../packages/*"]

tsconfig.json

@@ -13,15 +13,14 @@
     "isolatedModules": true,
     "jsx": "preserve",
     "incremental": true,
-    "baseUrl": ".",
     "paths": {
-      "@packages/env": ["packages/env/index.ts"],
-      "@packages/cqrs": ["packages/cqrs/index.ts"],
-      "@packages/agents": ["packages/agents/index.ts"],
-      "@packages/schema": ["packages/schema/index.ts"],
-      "@packages/notifications": ["packages/notifications/index.ts"],
-      "@packages/utils": ["packages/utils/index.ts"],
-      "@packages/utils-server": ["packages/utils-server/index.ts"],
+      "@packages/env": ["./packages/env/index.ts"],
+      "@packages/cqrs": ["./packages/cqrs/index.ts"],
+      "@packages/agents": ["./packages/agents/index.ts"],
+      "@packages/schema": ["./packages/schema/index.ts"],
+      "@packages/notifications": ["./packages/notifications/index.ts"],
+      "@packages/utils": ["./packages/utils/index.ts"],
+      "@packages/utils-server": ["./packages/utils-server/index.ts"],
     }
   },
   "include": ["apps/**/*", "packages/**/*"],