refactor(gui): remove redundant hasattr check in _terminate_process

Author: AAClause

basilisk/gui/conversation_tab.py

@@ -1021,7 +1021,7 @@ def _terminate_process(
 				log.warning("%s did not terminate, killing it", process_name)
 				process.kill()
 				# Give killed process a brief chance to be reaped
-				if hasattr(process, 'join') and process.is_alive():
+				if process.is_alive():
 					process.join(timeout=0.5)
 		except Exception as e:
 			log.error(

basilisk/gui/main_frame.py

@@ -651,9 +651,18 @@ def on_close_conversation(self, event: wx.Event | None):
 		current_tab = self.tabs_panels[current_tab_index]
 
 		# Clean up running resources for this tab only before closing
-		current_tab.cleanup_resources()
+		try:
+			current_tab.cleanup_resources()
+		except Exception as e:
+			# Log error but proceed to remove tab
+			log.error(
+				"Error cleaning up resources for tab at index %d: %s",
+				current_tab_index,
+				e,
+				exc_info=True,
+			)
 
-		# Remove the tab from the notebook and tabs list
+		# Remove the tab from the notebook and tabs list (always, even if cleanup failed)
 		self.notebook.DeletePage(current_tab_index)
 		self.tabs_panels.pop(current_tab_index)