style: remove f-string in log message

Author: clementb49

basilisk/config/account_config.py

@@ -148,7 +148,8 @@ def __init__(self, **data: Any):
 			super().__init__(**data)
 		except Exception as e:
 			log.error(
-				f"Error in account {e} the account will not be accessible",
+				"Error in account '%s' the account will not be accessible",
+				data.get("name", "Unknown"),
 				exc_info=e,
 			)
 			raise e
@@ -404,7 +405,8 @@ def default_account(self) -> Account:
 		account = self.get_account_from_info(self.default_account_info)
 		if not account:
 			log.warning(
-				f"Default account not found for id {self.default_account_info} using the first account"
+				"Default account not found for id %s using the first account",
+				self.default_account_info,
 			)
 			account = self[0]
 		return account
@@ -545,7 +547,10 @@ def add(self, account: Account):
 			raise ValueError("Account must be an instance of Account")
 		self.accounts.append(account)
 		log.debug(
-			f"Added account for {account.provider.name} ({account.name}, source: {account.source})"
+			"Added account for %s (%s, source: %s)",
+			account.provider.name,
+			account.name,
+			account.source,
 		)
 
 	def get_accounts_by_provider(

basilisk/config/conversation_profile.py

@@ -60,7 +60,8 @@ def __init__(self, **data: Any):
 			super().__init__(**data)
 		except Exception as e:
 			log.error(
-				f"Error in conversation profile {e}; the profile will not be accessible",
+				"Error in conversation profile '%s' the profile will not be accessible",
+				data.get("name", "unknown"),
 				exc_info=e,
 			)
 			raise e

basilisk/conversation/attached_file.py

@@ -106,10 +106,10 @@ def parse_supported_attachment_formats(
 	for mime_type in sorted(supported_attachment_formats):
 		exts = mimetypes.guess_all_extensions(mime_type)
 		if exts:
-			log.debug(f"Adding wildcard for MIME type {mime_type}: {exts}")
+			log.debug("Adding wildcard for MIME type %s: %s", mime_type, exts)
 			wildcard_parts.append("*" + ";*".join(exts))
 		else:
-			log.warning(f"No extensions found for MIME type {mime_type}")
+			log.warning("No extensions found for MIME type %s", mime_type)
 
 	wildcard = ";".join(wildcard_parts)
 	return wildcard
@@ -397,12 +397,12 @@ def remove_location(location: UPath):
 		Args:
 			location: The location of the file to remove.
 		"""
-		log.debug(f"Removing file at {location}")
+		log.debug("Removing file at %s", location)
 		try:
 			fs = location.fs
 			fs.rm(location.path)
 		except Exception as e:
-			log.error(f"Error deleting file at {location}: {e}")
+			log.error("Error deleting file at '%s': %s", location, e)
 
 	def read_as_plain_text(self) -> str:
 		"""Read the file as a plain text string.
@@ -531,7 +531,7 @@ def encode_base64(self) -> str:
 		"""
 		if self.size and self.size > 1024 * 1024 * 1024:
 			log.warning(
-				f"Large image ({self.display_size}) being encoded to base64"
+				"Large image (%s) being encoded to base64", self.display_size
 			)
 		return super().encode_base64()
 

basilisk/decorators.py

@@ -66,8 +66,9 @@ def wrapper(*args, **kwargs):
 		module_name = method.__module__
 		qualname = method.__qualname__
 		result = method(*args, **kwargs)
+		exec_time = time.time() - start
 		logger.debug(
-			f"{module_name}.{qualname} took {time.time() - start:.3f} seconds"
+			"%s.%s took %.3f seconds", module_name, qualname, exec_time
 		)
 		return result
 

basilisk/file_watcher.py

@@ -60,7 +60,7 @@ def on_modified(self, event: FileSystemEvent):
 		elif event.src_path == OPEN_BSKC_FILE:
 			self.on_open_bskc_file(event)
 		else:
-			logger.error(f"unknown event: {event}")
+			logger.error("unknown event: %s", event)
 
 	def on_focus_file(self, event: FileSystemEvent):
 		"""Handle modifications to the focus file with controlled event triggering.

basilisk/gui/account_dialog.py

@@ -974,7 +974,7 @@ def update_ui(self, event: wx.Event | None = None):
 			event: The event that triggered the update. If None, the update was not triggered by an event.
 		"""
 		account = self.account_manager[self.account_list.GetFirstSelected()]
-		log.debug(f"Selected account: {account}")
+		log.debug("Selected account: %s", account)
 		editable = account.source != AccountSource.ENV_VAR
 		self.edit_btn.Enable(editable)
 		self.remove_btn.Enable(editable)

basilisk/gui/conversation_tab.py

@@ -119,7 +119,7 @@ def open_conversation(
 				parent_window, "/path/to/conversation.json", "My Conversation"
 			)
 		"""
-		log.debug(f"Opening conversation from {file_path}")
+		log.debug("Opening conversation from %s", file_path)
 		storage_path = cls.conv_storage_path()
 		conversation = Conversation.open(file_path, storage_path)
 		title = conversation.title or default_title
@@ -741,7 +741,7 @@ def add_attachments(self, paths: list[str | AttachmentFile | ImageFile]):
 		Args:
 			paths: List of attachment file paths
 		"""
-		log.debug(f"Adding attachments: {paths}")
+		log.debug("Adding attachments: %s", paths)
 		for path in paths:
 			if isinstance(path, (AttachmentFile, ImageFile)):
 				self.attachment_files.append(path)
@@ -1202,7 +1202,7 @@ def on_submit(self, event: wx.CommandEvent):
 			target=self._handle_completion, kwargs=completion_kw
 		)
 		self.task.start()
-		log.debug(f"Task {self.task.ident} started")
+		log.debug("Task %s started", self.task.ident)
 
 	def on_stop_completion(self, event: wx.CommandEvent):
 		"""Handle the stopping of the current completion task.
@@ -1262,7 +1262,8 @@ def _handle_completion(self, engine: BaseEngine, **kwargs: dict[str, Any]):
 							new_block.response.citations.append(chunk_data)
 						case _:
 							log.warning(
-								f"Unknown chunk type in streaming response: {chunk_type}"
+								"Unknown chunk type in streaming response: %s",
+								chunk_type,
 							)
 			wx.CallAfter(self._post_completion_with_stream, new_block)
 		else:
@@ -1345,7 +1346,7 @@ def _end_task(self, success: bool = True):
 			success: Whether the task completed successfully
 		"""
 		self.task.join()
-		log.debug(f"Task {self.task.ident} ended")
+		log.debug("Task %s ended", self.task.ident)
 		self.task = None
 		stop_sound()
 		if success:
@@ -1414,7 +1415,7 @@ def save_conversation(self, file_path: str) -> bool:
 		Returns:
 		True if the conversation was successfully saved, False otherwise.
 		"""
-		log.debug(f"Saving conversation to {file_path}")
+		log.debug("Saving conversation to %s", file_path)
 		try:
 			self.conversation.save(file_path)
 			return True

basilisk/gui/history_msg_text_ctrl.py

@@ -567,7 +567,7 @@ def handle_speech_stream_buffer(self, new_text: str = ''):
 				# Concatenate new text to the buffer if no punctuation is found
 				self.speech_stream_buffer += new_text
 		except re.error as e:
-			logger.error(f"Regex error in _handle_speech_stream_buffer: {e}")
+			logger.error("Regex error in _handle_speech_stream_buffer: %s", e)
 			# Fallback: treat the entire text as a single chunk
 			self.speech_stream_buffer += new_text
 
@@ -653,7 +653,7 @@ def _handle_citations(citations: list[dict[str, Any]]) -> str:
 				case _:
 					# Translators: This is a citation format for unknown locations
 					location_text = _("Unknown location")
-					logger.warning(f"Unknown citation type: {citation}")
+					logger.warning("Unknown citation type: %s", citation)
 			if document_index is not None:
 				if document_title:
 					location_text = _(

basilisk/gui/main_frame.py

@@ -300,7 +300,7 @@ def on_hotkey(self, event):
 			case HotkeyAction.CAPTURE_FULL:
 				self.screen_capture(CaptureMode.FULL)
 			case _:
-				log.error(f"Unknown hotkey action: {event.GetId()}")
+				log.error("Unknown hotkey action: %s", event.GetId())
 
 	def toggle_visibility(self, event):
 		"""Toggle the visibility of the main application frame. If the frame is shown, it is minimized to the system tray. If it is hidden, it is restored.
@@ -334,7 +334,7 @@ def screen_capture(
 			screen_coordinates: Coordinates for partial screen capture (left, top, width, height). Defaults to None.
 			name: Custom name for the captured image. If not provided, a timestamp-based name is generated.
 		"""
-		log.debug(f"Capturing {capture_mode.value} screen")
+		log.debug("Capturing %s screen", capture_mode.value)
 		conv_tab = self.current_tab
 		if not conv_tab:
 			wx.MessageBox(
@@ -354,7 +354,7 @@ def screen_capture(
 			conv_tab.conv_storage_path / f"attachments/{capture_name}"
 		)
 		name = name or capture_name
-		log.debug(f"Capture file URL: {capture_path}")
+		log.debug("Capture file URL: %s", capture_path)
 		thread = ScreenCaptureThread(
 			self,
 			capture_path,
@@ -435,7 +435,7 @@ def on_quit(self, event: wx.Event | None):
 			if tab.task:
 				task_id = tab.task.ident
 				log.debug(
-					f"Waiting for conversation task {task_id} to finish..."
+					"Waiting for conversation task %s to finish...", task_id
 				)
 				tab.task.join()
 				log.debug("... is dead")
@@ -486,7 +486,8 @@ def on_new_default_conversation(self, event: wx.Event | None):
 		profile = config.conversation_profiles().default_profile
 		if profile:
 			log.info(
-				f"Creating a new conversation with default profile ({profile.name})"
+				"Creating a new conversation with default profile (%s)",
+				profile.name,
 			)
 		self.new_conversation(profile)
 
@@ -523,7 +524,7 @@ def on_new_conversation(self, event: wx.Event):
 		profile = self.get_selected_profile_from_menu(event)
 		if not profile:
 			return
-		log.info(f"Creating a new conversation with profile: {profile.name}")
+		log.info("Creating a new conversation with profile: %s", profile.name)
 		self.new_conversation(profile)
 
 	def refresh_tab_title(self, include_frame: bool = False):
@@ -780,7 +781,7 @@ def on_install_nvda_addon(self, event):
 			tmp_nvda_addon_path = os.path.join(
 				tempfile.gettempdir(), "basiliskllm.nvda-addon"
 			)
-			log.debug(f"Creating NVDA addon: {tmp_nvda_addon_path}")
+			log.debug("Creating NVDA addon: %s", tmp_nvda_addon_path)
 			with zipfile.ZipFile(
 				tmp_nvda_addon_path, 'w', zipfile.ZIP_DEFLATED
 			) as zipf:
@@ -794,7 +795,7 @@ def on_install_nvda_addon(self, event):
 			log.debug("NVDA addon created")
 			os.startfile(tmp_nvda_addon_path)
 		except Exception as e:
-			log.error(f"Failed to create NVDA addon: {e}")
+			log.error("Failed to create NVDA addon: %s", e)
 			wx.MessageBox(
 				_("Failed to create NVDA addon"),
 				_("Error"),
@@ -847,7 +848,7 @@ def on_view_log(self, event: wx.Event | None):
 		try:
 			os.startfile(get_log_file_path())
 		except Exception as e:
-			log.error(f"Failed to open log file: {e}")
+			log.error("Failed to open log file: %s", e)
 			wx.MessageBox(
 				_("Failed to open log file"), _("Error"), wx.OK | wx.ICON_ERROR
 			)
@@ -884,7 +885,7 @@ def show_dialog():
 				parent=self, title=_("New version available"), updater=updater
 			)
 			update_dialog.ShowModal()
-			log.debug(f"Update dialog shown: {update_dialog.IsShown()}")
+			log.debug("Update dialog shown: %s", update_dialog.IsShown())
 
 		wx.CallAfter(show_dialog)
 
@@ -901,7 +902,7 @@ def show_dialog():
 				parent=self, title=_("Downloading update"), updater=updater
 			)
 			download_dialog.ShowModal()
-			log.debug(f"Download dialog shown: {download_dialog.IsShown()}")
+			log.debug("Download dialog shown: %s", download_dialog.IsShown())
 
 		wx.CallAfter(show_dialog)
 
@@ -1005,7 +1006,7 @@ def on_apply_conversation_profile(self, event: wx.Event):
 		profile = self.get_selected_profile_from_menu(event)
 		if not profile:
 			return
-		log.info(f"Applying profile: {profile.name} to conversation")
+		log.info("Applying profile: %s to conversation", profile.name)
 		self.current_tab.apply_profile(profile)
 
 	def handle_no_account_configured(self):
@@ -1104,7 +1105,9 @@ def open_conversation(self, file_path: str):
 				style=wx.OK | wx.ICON_ERROR,
 			)
 			log.error(
-				f"Failed to open conversation file: {file_path}, error: {e}",
+				"Failed to open conversation file: %s, error: %s",
+				file_path,
+				e,
 				exc_info=e,
 			)
 

basilisk/gui/ocr_handler.py

@@ -85,13 +85,15 @@ def _handle_ocr_message(
 				self._handle_ocr_completion_message(message_type, data, dialog)
 			else:
 				log.warning(
-					f"Unknown message type in result queue: {message_type}"
+					"Unknown message type in result queue: %s", message_type
 				)
 		except Exception as e:
-			log.error(f"Error handling message: {str(e)}", exc_info=True)
+			log.error("Error handling message: %s", e, exc_info=True)
 			wx.MessageBox(
-				_("An error occurred while processing OCR results. Details:")
-				+ f"\n{e}",
+				_(
+					"An error occurred while processing OCR results. Details: \n%s"
+				)
+				% e,
 				_("Error"),
 				wx.OK | wx.ICON_ERROR,
 			)
@@ -167,7 +169,9 @@ def _display_ocr_result(self, data: Any) -> None:
 			wx.MessageBox(data, _("Result"), wx.OK | wx.ICON_INFORMATION)
 		else:
 			log.warning(
-				f"Unexpected OCR result data type or empty result: {type(data).__name__} - {data}"
+				"Unexpected OCR result data type or empty result: %s - %s",
+				type(data),
+				data,
 			)
 			wx.MessageBox(
 				_("OCR completed, but no text was extracted."),
@@ -213,13 +217,13 @@ def _cleanup_ocr_process(self, dialog: ProgressBarDialog) -> None:
 					log.warning("Process did not terminate, killing it")
 					self.process.kill()
 			except Exception as e:
-				log.error(f"Error terminating process: {str(e)}", exc_info=True)
+				log.error("Error terminating process: %", e, exc_info=True)
 
 		try:
 			if dialog and dialog.IsShown():
 				dialog.Destroy()
 		except Exception as e:
-			log.error(f"Error destroying dialog: {str(e)}", exc_info=True)
+			log.error("Error destroying dialog: %s", e, exc_info=True)
 
 		self.ocr_button.Enable()
 		self.process = None