chore: implement review comment

Author: clementb49

basilisk/completion_handler.py

@@ -59,7 +59,6 @@ def __init__(
 		"""Initialize the completion handler.
 
 		Args:
-			parent: The parent window for displaying error dialogs
 			on_completion_start: Callback called when completion starts
 			on_completion_end: Callback called when completion ends (success flag)
 			on_stream_chunk: Callback called for each streaming chunk
@@ -127,6 +126,7 @@ def stop_completion(self):
 			self._stop_completion = True
 			logger.debug("Stopping completion task: %s", self.task.ident)
 			self.task.join(timeout=1)
+		if self.on_completion_end:
 			wx.CallAfter(self.on_completion_end, False)
 
 	def is_running(self) -> bool:

basilisk/gui/conversation_tab.py

@@ -661,8 +661,6 @@ def on_stop_completion(self, event: wx.CommandEvent):
 		"""
 		self.completion_handler.stop_completion()
 
-		self._stop_completion = False
-
 	def generate_conversation_title(self):
 		"""Generate a title for the conversation tab by using the AI model to analyze the conversation content.
 

basilisk/gui/edit_block_dialog.py

@@ -227,7 +227,7 @@ def init_ui(self):
 		btn_sizer.AddButton(wx.Button(self, wx.ID_CANCEL))
 
 		self.Bind(wx.EVT_BUTTON, self.on_ok, id=wx.ID_OK)
-		self.Bind(wx.EVT_BUTTON, self.on_cancxel, id=wx.ID_CANCEL)
+		self.Bind(wx.EVT_BUTTON, self.on_cancel, id=wx.ID_CANCEL)
 
 		btn_sizer.Realize()
 
@@ -354,7 +354,7 @@ def on_ok(self, event: wx.CommandEvent):
 			self.block.response.content = self.response_txt.GetValue()
 		event.Skip()
 
-	def on_cancxel(self, event: wx.CommandEvent):
+	def on_cancel(self, event: wx.CommandEvent):
 		"""Handle the Cancel button click.
 
 		Closes the dialog without saving changes.

basilisk/gui/prompt_attachments_panel.py

@@ -445,6 +445,8 @@ def add_attachment_from_url(self, url: str):
 			)
 			return
 		except Exception as err:
+			if isinstance(err, (KeyboardInterrupt, SystemExit)):
+				raise
 			log.error(err, exc_info=True)
 			wx.CallAfter(
 				wx.MessageBox,
@@ -476,7 +478,7 @@ def on_show_attachment_details(self, event: wx.CommandEvent):
 		Args:
 			event: Event triggered by the show attachment details action
 		"""
-		current_attachment = self.selected_attachment_file()
+		current_attachment = self.selected_attachment_file
 		if not current_attachment:
 			return
 
@@ -507,7 +509,7 @@ def on_attachments_remove(self, event: wx.CommandEvent):
 			event: Event triggered by the remove attachment action
 		"""
 		selection = self.attachments_list.GetFirstSelected()
-		current_attachment = self.selected_attachment_file()
+		current_attachment = self.selected_attachment_file
 		if not current_attachment:
 			return
 
@@ -530,11 +532,11 @@ def on_copy_attachment_location(self, event: wx.CommandEvent):
 		Args:
 			event: Event triggered by the copy attachment location action
 		"""
-		current_attachment = self.selected_attachment_file()
+		current_attachment = self.selected_attachment_file
 		if not current_attachment:
 			return
 
-		location = "\"%s\"" % str(current_attachment.location)
+		location = f'"{current_attachment.location}"'
 		with wx.TheClipboard as clipboard:
 			clipboard.SetData(wx.TextDataObject(location))
 
@@ -704,12 +706,21 @@ def resize_all_attachments(self):
 		for attachment in self.attachment_files:
 			if not attachment.mime_type.startswith("image/"):
 				continue
-			attachment.resize(
-				self.conv_storage_path,
-				config.conf().images.max_width,
-				config.conf().images.max_height,
-				config.conf().images.quality,
-			)
+			try:
+				attachment.resize(
+					self.conv_storage_path,
+					config.conf().images.max_width,
+					config.conf().images.max_height,
+					config.conf().images.quality,
+				)
+			except Exception as e:
+				log.error(
+					"Error resizing image attachment %s: %s",
+					attachment.location,
+					e,
+					exc_info=True,
+				)
+				continue
 
 	def ensure_model_compatibility(
 		self, current_model: ProviderAIModel | None