You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not tested: Any transform, any sensor, Signal K protocol, networking, configuration persistence, JSON serialization, or the entire connect_to pipeline.
Given the number of correctness bugs found in this review (variable shadowing, assignment typos, buffer resize bugs, uninitialized values), the lack of unit tests for transforms is a significant risk.
Recommendation
Priority areas for test coverage:
Transforms -- especially CurveInterpolator, MovingAverage, LambdaTransform, Hysteresis, Frequency
JSON serialization -- to_json/from_json round-trip tests for all configurable objects
Nullable -- edge cases for each type specialization
Description
The project has only 6 test files covering:
Not tested: Any transform, any sensor, Signal K protocol, networking, configuration persistence, JSON serialization, or the entire
connect_topipeline.Given the number of correctness bugs found in this review (variable shadowing, assignment typos, buffer resize bugs, uninitialized values), the lack of unit tests for transforms is a significant risk.
Recommendation
Priority areas for test coverage:
CurveInterpolator,MovingAverage,LambdaTransform,Hysteresis,Frequencyto_json/from_jsonround-trip tests for all configurable objectsFound during code review (2026-03-25)