fix(daemon): tighten section-heading match, fix session:notes subcommand, drop unused import

- Writer splitBlocks uses exact line equality instead of trimEnd() to
  avoid re-detecting section headings inside list items (e.g. bullets
  containing 'Key steps:' or 'Outcome:' as quoted text).
- Move session:notes from top-level program command to session subcommand
  (session notes <key>) and update tests accordingly.
- Remove unused SESSION_NOTES_FILENAME import from consolidator.

Author: NicholaiVogel

platform/daemon/src/session-notes-consolidator.ts

@@ -26,7 +26,6 @@ import { logger } from "./logger";
 import type { LlmProvider } from "./pipeline/provider";
 import { redactSecrets } from "./session-checkpoints";
 import {
-	SESSION_NOTES_FILENAME,
 	appendTaskSection,
 	findLowestMissingIndex,
 	isNotesFileFresh,

platform/daemon/src/session-notes-writer.test.ts

@@ -256,4 +256,40 @@ Twelfth task.
 		expect(existsSync(dir)).toBe(true);
 		expect(existsSync(join(dir, SESSION_NOTES_FILENAME))).toBe(true);
 	});
+
+	test("does not misparse section labels that appear inside list items", () => {
+		// Regression: the previous splitBlocks used line.trimEnd() to match
+		// section headings, so a bullet like `- "Key steps:"` inside a
+		// Failures block would re-detect as a new section header and shuffle
+		// every line below it into the wrong bucket.
+		appendTaskSection({
+			sessionKey: "labels-in-bullets",
+			agentId: "default",
+			harness: "opencode",
+			cwd: "/tmp",
+			task: {
+				taskIndex: 1,
+				outcome: "Validated the parser.",
+				failures: [
+					'The user said "Key steps:" should be lowercase.',
+					'A bullet that ends with "Outcome:" is just text.',
+				],
+				keySteps: ["Tightened the heading match."],
+			},
+			agentsDir: tmpRoot,
+		});
+		const read = readSessionNotes("labels-in-bullets", tmpRoot);
+		expect(read.ok).toBe(true);
+		if (!read.ok) return;
+		expect(read.file.tasks).toHaveLength(1);
+		const task = read.file.tasks[0]!;
+		// Both quoted-label bullets are preserved as failures, not mis-bucketed.
+		expect(task.failures).toEqual([
+			'The user said "Key steps:" should be lowercase.',
+			'A bullet that ends with "Outcome:" is just text.',
+		]);
+		expect(task.keySteps).toEqual(["Tightened the heading match."]);
+		// Outcome was not contaminated by the "Outcome:" substring.
+		expect(task.outcome).toBe("Validated the parser.");
+	});
 });

platform/daemon/src/session-notes-writer.ts

@@ -318,9 +318,15 @@ function splitBlocks(body: string): Record<string, string> {
 	const lines = body.split("\n");
 	const result: Record<string, string[]> = {};
 	let current: string | null = null;
+	// Match section headings only when the line is exactly one of the six
+	// canonical labels (no leading whitespace, no trailing content). A loose
+	// trimEnd-based match would re-detect headings inside list items, e.g.
+	// `- "Key steps:"` in a Failures block, and shuffle every line below
+	// it into the wrong bucket. The writer's renderer always emits at
+	// column 0 with no trailing whitespace, so exact equality is safe.
 	for (const line of lines) {
-		if ((REQUIRED_TASK_SECTIONS as readonly string[]).includes(line.trimEnd())) {
-			current = line.trimEnd();
+		if ((REQUIRED_TASK_SECTIONS as readonly string[]).includes(line)) {
+			current = line;
 			result[current] = [];
 		} else if (current) {
 			result[current].push(line);

surfaces/cli/src/commands/session.test.ts

@@ -95,7 +95,7 @@ describe("registerSessionCommands search", () => {
 	});
 });
 
-describe("registerSessionCommands session:notes", () => {
+describe("registerSessionCommands session notes", () => {
 	test("calls the notes route and prints json", async () => {
 		const lines: string[] = [];
 		console.log = (line?: unknown) => {
@@ -135,7 +135,7 @@ describe("registerSessionCommands session:notes", () => {
 			},
 		});
 
-		await program.parseAsync(["node", "test", "session:notes", "test", "--json"]);
+		await program.parseAsync(["node", "test", "session", "notes", "test", "--json"]);
 
 		expect(capturedPath).toBe("/api/sessions/test/notes");
 		expect(lines).toHaveLength(1);
@@ -182,7 +182,7 @@ describe("registerSessionCommands session:notes", () => {
 			},
 		});
 
-		await program.parseAsync(["node", "test", "session:notes", "test", "--task", "2", "--json"]);
+		await program.parseAsync(["node", "test", "session", "notes", "test", "--task", "2", "--json"]);
 
 		expect(capturedPath).toBe("/api/sessions/test/notes?task=2");
 	});
@@ -208,7 +208,7 @@ describe("registerSessionCommands session:notes", () => {
 		});
 
 		try {
-			await program.parseAsync(["node", "test", "session:notes", "missing"]);
+			await program.parseAsync(["node", "test", "session", "notes", "missing"]);
 		} catch {
 			/* swallow the synthetic exit */
 		}

surfaces/cli/src/commands/session.ts

@@ -136,10 +136,9 @@ export function registerSessionCommands(program: Command, deps: SessionDeps): vo
 			console.log(chalk.green(`  Session ${sessionKey.slice(0, 12)} bypass removed — hooks re-enabled`));
 		});
 
-	program
-		.command("session:notes")
+	session
+		.command("notes <session-key>")
 		.description("Read the structured per-session notes file (frontmatter + numbered Task N sections)")
-		.argument("<session-key>", "Session key (thread_id) to read")
 		.option("--task <n>", "Scope to a single task index", (v) => Number.parseInt(v, 10))
 		.option("--json", "Output as JSON", false)
 		.action(async (sessionKey: string, options: { task?: number; json?: boolean }) => {