fix(cli): respect active harnesses during sync (#630)

Author: NicholaiVogel

docs/CLI.md

@@ -701,10 +701,12 @@ Options:
 ---
 
 Sync hooks, extensions, built-in template files, and skills to your `$SIGNET_WORKSPACE/` directory,
-and re-register hooks for any detected harnesses. Run this after an
+and re-register hooks for the active harnesses listed in `agent.yaml`. Run this after an
 upgrade if built-in skills appear stale or hooks need updating. If OpenClaw is still configured on
 the legacy Signet hook path, `signet sync` now migrates it to the plugin
 runtime path automatically so full lifecycle capture resumes.
+The command may report installed harnesses it detects on disk, but inactive
+harnesses are not modified.
 
 ```bash
 signet sync

platform/core/src/__tests__/harness-config.test.ts

@@ -0,0 +1,39 @@
+import { describe, expect, test } from "bun:test";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { loadConfiguredHarnesses, parseHarnessList } from "../harness-config";
+
+describe("parseHarnessList", () => {
+	test("normalizes array and comma-separated harness config", () => {
+		expect(parseHarnessList(["pi", " codex ", "", 42])).toEqual(["pi", "codex"]);
+		expect(parseHarnessList("pi, codex,,opencode")).toEqual(["pi", "codex", "opencode"]);
+	});
+});
+
+describe("loadConfiguredHarnesses", () => {
+	test("loads active harnesses from agent.yaml", () => {
+		const root = mkdtempSync(join(tmpdir(), "signet-harness-config-"));
+
+		try {
+			mkdirSync(root, { recursive: true });
+			writeFileSync(join(root, "agent.yaml"), "harnesses:\n  - pi\n  - opencode\n");
+
+			expect(loadConfiguredHarnesses(root)).toEqual(["pi", "opencode"]);
+		} finally {
+			rmSync(root, { recursive: true, force: true });
+		}
+	});
+
+	test("returns empty list when no config declares harnesses", () => {
+		const root = mkdtempSync(join(tmpdir(), "signet-harness-config-empty-"));
+
+		try {
+			writeFileSync(join(root, "agent.yaml"), "agent:\n  name: test\n");
+
+			expect(loadConfiguredHarnesses(root)).toEqual([]);
+		} finally {
+			rmSync(root, { recursive: true, force: true });
+		}
+	});
+});

platform/core/src/harness-config.ts

@@ -0,0 +1,39 @@
+import { existsSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import { parseSimpleYaml } from "./yaml";
+
+const CONFIG_FILES = ["agent.yaml", "AGENT.yaml", "config.yaml"] as const;
+
+export function loadConfiguredHarnesses(agentsDir: string): readonly string[] {
+	for (const name of CONFIG_FILES) {
+		const path = join(agentsDir, name);
+		if (!existsSync(path)) continue;
+
+		try {
+			const parsed = parseSimpleYaml(readFileSync(path, "utf-8"));
+			if (!isRecord(parsed)) return [];
+			return parseHarnessList(parsed.harnesses);
+		} catch {
+			return [];
+		}
+	}
+
+	return [];
+}
+
+export function parseHarnessList(value: unknown): readonly string[] {
+	if (Array.isArray(value)) {
+		return value.flatMap((entry) => (typeof entry === "string" && entry.trim().length > 0 ? [entry.trim()] : []));
+	}
+	if (typeof value === "string") {
+		return value
+			.split(",")
+			.map((entry) => entry.trim())
+			.filter((entry) => entry.length > 0);
+	}
+	return [];
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+	return typeof value === "object" && value !== null;
+}

platform/core/src/index.ts

@@ -105,6 +105,7 @@ export {
 	resolveNetworkBinding,
 } from "./network";
 export type { NetworkMode } from "./network";
+export { loadConfiguredHarnesses, parseHarnessList } from "./harness-config";
 export { resolveSignetDaemonUrl } from "./daemon-url";
 export type { SignetDaemonUrlOptions } from "./daemon-url";
 export {

platform/daemon/src/daemon.ts

@@ -17,6 +17,7 @@ import {
 	type AgentDefinition,
 	type PipelineSynthesisConfig,
 	buildArchitectureDoc,
+	loadConfiguredHarnesses,
 	normalizeAgentRosterEntry,
 	parseSimpleYaml,
 	stripSignetBlock,
@@ -248,6 +249,7 @@ const SYNC_DEBOUNCE_MS = 2000;
 async function syncHarnessConfigs() {
 	const agentsMdPath = join(AGENTS_DIR, "AGENTS.md");
 	if (!existsSync(agentsMdPath)) return;
+	const activeHarnesses = new Set(loadConfiguredHarnesses(AGENTS_DIR));
 
 	const rawContent = await Bun.file(agentsMdPath).text();
 	const content = stripSignetBlock(rawContent);
@@ -309,7 +311,7 @@ ${fileList}
 	const composed = content + identityExtras;
 
 	const opencodeDir = join(homedir(), ".config", "opencode");
-	if (existsSync(opencodeDir)) {
+	if (activeHarnesses.has("opencode") && existsSync(opencodeDir)) {
 		try {
 			const opencodeAgentsPath = join(opencodeDir, "AGENTS.md");
 			if (await writeFileIfChangedAsync(opencodeAgentsPath, buildHeader("AGENTS.md") + composed)) {
@@ -673,6 +675,8 @@ function startFileWatcher() {
 	watcher = watch(
 		[
 			join(AGENTS_DIR, "agent.yaml"),
+			join(AGENTS_DIR, "AGENT.yaml"),
+			join(AGENTS_DIR, "config.yaml"),
 			join(AGENTS_DIR, "AGENTS.md"),
 			join(AGENTS_DIR, "SOUL.md"),
 			join(AGENTS_DIR, "MEMORY.md"),
@@ -693,7 +697,7 @@ function startFileWatcher() {
 		scheduleAutoCommit(path);
 
 		const base = basename(path);
-		if (base === "agent.yaml" || base === "AGENT.yaml") {
+		if (base === "agent.yaml" || base === "AGENT.yaml" || base === "config.yaml") {
 			try {
 				reloadAuthState(AGENTS_DIR);
 				logger.info("config", "Auth config reloaded from disk");
@@ -702,7 +706,16 @@ function startFileWatcher() {
 			}
 		}
 
-		const SYNC_TRIGGER_FILES = ["AGENTS.md", "SOUL.md", "IDENTITY.md", "USER.md", "MEMORY.md"];
+		const SYNC_TRIGGER_FILES = [
+			"agent.yaml",
+			"AGENT.yaml",
+			"config.yaml",
+			"AGENTS.md",
+			"SOUL.md",
+			"IDENTITY.md",
+			"USER.md",
+			"MEMORY.md",
+		];
 		const normalizedForSync = path.replace(/\\/g, "/");
 		const isAgentSubdir = normalizedForSync.includes(`${AGENTS_DIR.replace(/\\/g, "/")}/agents/`);
 		if (SYNC_TRIGGER_FILES.some((f) => path.endsWith(f)) || isAgentSubdir) {

surfaces/cli/src/features/sync.test.ts

@@ -101,6 +101,55 @@ describe("syncTemplates workspace detection", () => {
 			console.log = origLog;
 		}
 	});
+
+	it("only re-registers hooks for harnesses configured in agent.yaml", async () => {
+		const root = mkdtempSync(join(tmpdir(), "sync-active-harnesses-"));
+		const basePath = join(root, "agents");
+		const origLog = console.log;
+
+		try {
+			process.env.HOME = root;
+			mkdirSync(basePath, { recursive: true });
+			mkdirSync(join(root, ".codex"), { recursive: true });
+			mkdirSync(join(root, ".config", "opencode"), { recursive: true });
+			writeFileSync(join(root, ".codex", "config.toml"), "[model]\n");
+			writeFileSync(join(basePath, "agent.yaml"), "harnesses:\n  - pi\n");
+
+			const logs: string[] = [];
+			console.log = (...args: unknown[]) => logs.push(args.join(" "));
+			const configureHarnessHooks = mock(async () => {});
+
+			await syncTemplates({
+				agentsDir: basePath,
+				configureHarnessHooks,
+				getSkillsSourceDir: () => join(root, "skills-src"),
+				getTemplatesDir: () => join(root, "templates"),
+				signetLogo: () => "signet",
+				syncBuiltinSkills: () => ({ installed: [], updated: [], skipped: [] }),
+				syncNativeEmbeddingModel: async () => ({ status: "current", message: "ready" }),
+				syncPredictorBinary: async () => ({ status: "current", message: "ready" }),
+				syncWorkspaceSourceRepo: async () => ({
+					status: "current",
+					path: join(basePath, "signetai"),
+					message: "current",
+					branch: "main",
+					defaultBranch: "main",
+				}),
+			});
+
+			expect(configureHarnessHooks.mock.calls.map((call) => call[0])).toEqual(["pi"]);
+			const output = logs.join("\n");
+			expect(output).toContain("Installed harnesses detected:");
+			expect(output).toContain("codex");
+			expect(output).toContain("opencode");
+			expect(output).toContain("Installed but inactive:");
+			expect(output).not.toContain("hooks re-registered for codex");
+			expect(output).not.toContain("hooks re-registered for opencode");
+		} finally {
+			console.log = origLog;
+			rmSync(root, { recursive: true, force: true });
+		}
+	});
 });
 
 describe("syncTemplates openclaw migration", () => {
@@ -113,6 +162,7 @@ describe("syncTemplates openclaw migration", () => {
 			process.env.HOME = root;
 			process.env.OPENCLAW_CONFIG_PATH = configPath;
 			mkdirSync(basePath, { recursive: true });
+			writeFileSync(join(basePath, "agent.yaml"), "harnesses:\n  - openclaw\n");
 
 			writeFileSync(
 				configPath,
@@ -194,6 +244,7 @@ describe("syncTemplates openclaw migration", () => {
 			process.env.OPENCLAW_CONFIG_PATH = openClawConfigPath;
 			process.env.CLAWDBOT_CONFIG_PATH = clawdbotConfigPath;
 			mkdirSync(basePath, { recursive: true });
+			writeFileSync(join(basePath, "agent.yaml"), "harnesses:\n  - openclaw\n");
 
 			writeFileSync(
 				openClawConfigPath,

surfaces/cli/src/features/sync.ts

@@ -1,12 +1,14 @@
 import { copyFileSync, existsSync } from "node:fs";
 import { homedir } from "node:os";
 import { join } from "node:path";
-import { GeminiConnector } from "@signet/connector-gemini";
-import { HermesAgentConnector } from "@signet/connector-hermes-agent";
-import { OhMyPiConnector } from "@signet/connector-oh-my-pi";
 import { OpenClawConnector } from "@signet/connector-openclaw";
-import { PiConnector } from "@signet/connector-pi";
-import type { WorkspaceSourceRepoSyncResult } from "@signet/core";
+import {
+	type WorkspaceSourceRepoSyncResult,
+	getOhMyPiConfigPath,
+	getPiConfigPath,
+	loadConfiguredHarnesses,
+	resolveHermesRepoPath,
+} from "@signet/core";
 import chalk from "chalk";
 
 interface SkillSync {
@@ -149,7 +151,23 @@ async function syncNative(basePath: string, deps: Deps): Promise<number> {
 
 async function syncHarnessHooks(basePath: string, deps: Deps): Promise<number> {
 	let synced = 0;
-	for (const harness of detectHarnesses()) {
+	const harnesses = [...loadConfiguredHarnesses(basePath)];
+	const detected = detectInstalledHarnesses();
+	if (detected.length > 0) {
+		console.log(chalk.dim(`  Installed harnesses detected: ${detected.join(", ")}`));
+	}
+
+	if (harnesses.length === 0) {
+		console.log(chalk.dim("  No active harnesses configured; skipping hook re-registration"));
+		return 0;
+	}
+
+	const inactive = detected.filter((harness) => !harnesses.includes(harness));
+	if (inactive.length > 0) {
+		console.log(chalk.dim(`  Installed but inactive: ${inactive.join(", ")}`));
+	}
+
+	for (const harness of harnesses) {
 		try {
 			let runtimePath: "plugin" | "legacy" | undefined;
 			if (harness === "openclaw") {
@@ -180,34 +198,32 @@ async function syncHarnessHooks(basePath: string, deps: Deps): Promise<number> {
 	return synced;
 }
 
-function detectHarnesses(): string[] {
+function detectInstalledHarnesses(): string[] {
 	const found: string[] = [];
+	const home = process.env.HOME ?? homedir();
 
-	if (existsSync(join(homedir(), ".claude", "settings.json"))) {
+	if (existsSync(join(home, ".claude", "settings.json"))) {
 		found.push("claude-code");
 	}
-	if (
-		existsSync(join(homedir(), ".config", "signet", "bin", "codex")) ||
-		existsSync(join(homedir(), ".codex", "config.toml"))
-	) {
+	if (existsSync(join(home, ".config", "signet", "bin", "codex")) || existsSync(join(home, ".codex", "config.toml"))) {
 		found.push("codex");
 	}
-	if (existsSync(join(homedir(), ".config", "opencode"))) {
+	if (existsSync(join(home, ".config", "opencode"))) {
 		found.push("opencode");
 	}
 	if (new OpenClawConnector().isInstalled()) {
 		found.push("openclaw");
 	}
-	if (new OhMyPiConnector().isInstalled()) {
+	if (existsSync(getOhMyPiConfigPath())) {
 		found.push("oh-my-pi");
 	}
-	if (new HermesAgentConnector().isInstalled()) {
+	if (resolveHermesRepoPath() !== null || existsSync(join(home, ".hermes"))) {
 		found.push("hermes-agent");
 	}
-	if (new GeminiConnector().isInstalled()) {
+	if (existsSync(join(home, ".gemini", "settings.json"))) {
 		found.push("gemini");
 	}
-	if (new PiConnector().isInstalled()) {
+	if (existsSync(getPiConfigPath())) {
 		found.push("pi");
 	}