Merge remote-tracking branch 'origin/dev' into symphony/SYM-35

# Conflicts:
#	src/runtime/server/controllers/run-controller.ts

Author: Symphony Agent

bun.lock

@@ -3,6 +3,7 @@ import {
   useCallback,
   useEffect,
   useMemo,
+  useRef,
   useState,
 } from "react";
 import { AveragesTable } from "./components/AveragesTable.tsx";
@@ -694,7 +695,7 @@ function RunsView({ request }: { request: ServerRequest }) {
   );
 }
 
-function RunDetailView({
+export function RunDetailView({
   runId,
   request,
   token,
@@ -707,50 +708,73 @@ function RunDetailView({
   const [error, setError] = useState<string | null>(null);
   const [selectedOrdinal, setSelectedOrdinal] = useState<number | null>(null);
   const [cancelling, setCancelling] = useState(false);
+  const requestRef = useRef(request);
+  const activeRunIdRef = useRef(runId);
+  const mountedRef = useRef(true);
 
-  const loadRun = useCallback(() => {
-    return request<RunResponse>(`/api/runs/${encodeURIComponent(runId)}`)
-      .then((data) => {
-        setRun(data.run);
-        setError(null);
-      })
-      .catch((err) => {
-        setError(err instanceof Error ? err.message : String(err));
-      });
-  }, [request, runId]);
+  requestRef.current = request;
+  activeRunIdRef.current = runId;
 
   useEffect(() => {
-    let cancelled = false;
-    loadRun().then(() => {
-      if (cancelled) return;
-    });
+    mountedRef.current = true;
     return () => {
-      cancelled = true;
+      mountedRef.current = false;
     };
+  }, []);
+
+  const loadRun = useCallback(async () => {
+    const expectedRunId = runId;
+    try {
+      const data = await requestRef.current<RunResponse>(
+        `/api/runs/${encodeURIComponent(expectedRunId)}`,
+      );
+      if (!mountedRef.current || activeRunIdRef.current !== expectedRunId) {
+        return;
+      }
+      setRun(data.run);
+      setError(null);
+    } catch (err) {
+      if (!mountedRef.current || activeRunIdRef.current !== expectedRunId) {
+        return;
+      }
+      setError(err instanceof Error ? err.message : String(err));
+    }
+  }, [runId]);
+
+  const loadRunRef = useRef(loadRun);
+  loadRunRef.current = loadRun;
+
+  useEffect(() => {
+    setRun(null);
+    setError(null);
+    setSelectedOrdinal(null);
+    void loadRun();
   }, [loadRun]);
 
   useEffect(() => {
-    if (!run || run.status !== "running") {
-      return;
-    }
     const tokenQuery = token
       ? `?access_token=${encodeURIComponent(token)}`
       : "";
     const events = new EventSource(
       `/api/runs/${encodeURIComponent(runId)}/events${tokenQuery}`,
     );
     const refetch = () => {
-      void loadRun();
+      void loadRunRef.current();
+    };
+    const refetchAndClose = () => {
+      refetch();
+      events.close();
     };
+    events.addEventListener("snapshot", refetch);
     events.addEventListener("suite_started", refetch);
     events.addEventListener("scenario_started", refetch);
     events.addEventListener("scenario_finished", refetch);
     events.addEventListener("scenario_error", refetch);
-    events.addEventListener("run_finished", refetch);
-    events.addEventListener("run_cancelled", refetch);
-    events.addEventListener("run_error", refetch);
+    events.addEventListener("run_finished", refetchAndClose);
+    events.addEventListener("run_cancelled", refetchAndClose);
+    events.addEventListener("run_error", refetchAndClose);
     return () => events.close();
-  }, [loadRun, run, runId, token]);
+  }, [runId, token]);
 
   const cancelRun = async () => {
     setCancelling(true);

dashboard/dist/index.html

@@ -155,6 +155,7 @@ export function CompareView({ token, apiBase = "" }: CompareViewProps) {
   const [pickerOpen, setPickerOpen] = useState(runIds.length < 2);
   const [availableRuns, setAvailableRuns] = useState<RunOption[]>([]);
   const [picker, setPicker] = useState<Set<string>>(new Set(runIds));
+  const pickerCanApply = picker.size >= 2 && picker.size <= 10;
 
   const fetchRuns = useCallback(async () => {
     try {
@@ -316,7 +317,9 @@ export function CompareView({ token, apiBase = "" }: CompareViewProps) {
               </li>
             ))}
           </ul>
-          <button type="submit">Apply</button>
+          <button type="submit" disabled={!pickerCanApply}>
+            Apply
+          </button>
         </form>
       )}
 
@@ -401,6 +404,11 @@ export function CompareView({ token, apiBase = "" }: CompareViewProps) {
               ))}
             </tbody>
           </table>
+          {filteredScenarios.length === 0 && (
+            <p className="compare-hint">
+              No aligned scenario rows match this comparison.
+            </p>
+          )}
         </>
       )}
 

dashboard/src/App.tsx

@@ -1,6 +1,6 @@
 # Workspace Inventory
 
-Generated: 2026-04-17T15:44:17.421Z
+Generated: 2026-04-17T16:26:34.861Z
 
 ```text
   AGENTS.md
@@ -426,13 +426,15 @@ tests/unit/
 tests/unit/persistence/
   tests/unit/persistence/factory.test.ts
   tests/unit/persistence/migrations.test.ts
+  tests/unit/persistence/postgres-backend.test.ts
   tests/unit/persistence/url.test.ts
   tests/unit/report.test.ts
   tests/unit/runner.test.ts
 tests/unit/server/
   tests/unit/server/auth.test.ts
   tests/unit/server/comparison.test.ts
   tests/unit/server/config.test.ts
+  tests/unit/server/inline-dashboard.test.ts
   tests/unit/server/selection.test.ts
   tests/unit/server/streams.test.ts
   tests/unit/simulator.test.ts

dashboard/src/components/CompareView.tsx

@@ -27,6 +27,7 @@ Last validated against `platform.md`: 2026-04-17
 - [x] API CORS allows only same-origin loopback by default
 - [x] Read-only HTTP and UI surfaces browse persisted run history
 - [x] Live run events stream through Server-Sent Events with replay support
+- [x] Run executor failures are logged and persisted
 - [x] Run control starts validated ad-hoc or preset-backed runs
 - [x] Cancellation cooperatively stops a server-managed run
 - [x] Presets save cross-file scenario selections for one-click rerun

docs/generated/workspace-inventory.md

@@ -24,10 +24,11 @@ Derived from `platform.md`. Every scenario should have a coverage owner.
 | API CORS allows only same-origin loopback by default | `tests/integration/server/read-only.test.ts` + `tests/unit/server/config.test.ts` | ✅ covered |
 | Read-only HTTP and UI surfaces browse persisted run history | `tests/integration/server/read-only.test.ts` + dashboard build/typecheck | ✅ covered |
 | Live run events stream through Server-Sent Events with replay support | `tests/integration/server/write-control.test.ts` + `tests/unit/server/streams.test.ts` | ✅ covered |
+| Run executor failures are logged and persisted | `tests/integration/server/write-control.test.ts` | ✅ covered |
 | Run control starts validated ad-hoc or preset-backed runs | `tests/integration/server/write-control.test.ts` | ✅ covered |
 | Cancellation cooperatively stops a server-managed run | `tests/integration/server/write-control.test.ts` | ✅ covered |
 | Presets save cross-file scenario selections for one-click rerun | `tests/integration/server/write-control.test.ts` + `tests/unit/server/selection.test.ts` | ✅ covered |
-| Comparison workspace diffs 2 to 10 historical runs | `tests/integration/server/comparisons.test.ts` + dashboard compare-view component tests | ⏳ planned |
+| Comparison workspace diffs 2 to 10 historical runs | `tests/integration/server/comparisons.test.ts` + `tests/unit/dashboard/compare-view.test.tsx` | ⏳ integration/unit covered; browser E2E planned |
 | Docker image boots safely with SQLite-on-volume persistence | `Dockerfile` + `docker-compose.yml` + `docs/playbooks/agent-probe-server.md` | ✅ covered |
 | Database URL credentials stay redacted in operator-visible output | `tests/unit/persistence/url.test.ts` + `tests/unit/server/config.test.ts` | ✅ covered |
 | Docker Compose readiness waits for server readiness | `docker-compose.yml` + `docs/playbooks/agent-probe-server.md` + `docker compose config` | ✅ covered |

docs/product-specs/current-state.md

@@ -208,6 +208,16 @@ events, supports reconnect via `Last-Event-ID` from an in-memory replay buffer
 for the most recent events, falls back to persisted run detail for events older
 than the buffer, and always emits a terminal event before closing the stream.
 
+### Run executor failures are logged and persisted
+
+**Given** a run launched through `agentprobe start-server` fails inside the
+server-side run executor
+**When** no SSE client is connected or the connected client disconnects before
+the failure is observed
+**Then** the server writes a structured `run_executor` error line to stderr,
+persists the failure on the run record for later `/api/runs/:runId` reads, and
+publishes a terminal `run_error` event for any active stream subscribers.
+
 ### Run control starts validated ad-hoc or preset-backed runs
 
 **Given** an `agentprobe start-server` instance with a resolvable `./data` root
@@ -246,13 +256,15 @@ snapshot.
 ### Comparison workspace diffs 2 to 10 historical runs
 
 **Given** at least two persisted runs, preferably launched from the same preset
-**When** the operator requests `GET /api/comparisons?run_ids=a,b[,...]` or opens
-the `/compare` workspace
+**When** the operator requests
+`GET /api/comparisons?run_ids=<run-uuid>,<run-uuid>[,...]` or opens the
+`/compare` workspace
 **Then** the server returns a scenario-aligned payload with per-run pass/fail,
 score delta, `status_change`, and summary buckets for improved, regressed, and
 unchanged scenarios; scenarios missing from one side surface as `present_in`
 entries rather than failing the request; and the request rejects any count
-below 2 or above 10 run IDs with a structured validation error.
+below 2 or above 10 run IDs, malformed run UUIDs, or duplicate run IDs with a
+structured validation error.
 
 ### Docker image boots safely with SQLite-on-volume persistence
 

docs/product-specs/e2e-checklist.md

@@ -31,6 +31,9 @@
     "@types/node": "^25.6.0",
     "@types/nunjucks": "^3.2.6",
     "bun-types": "^1.3.12",
+    "happy-dom": "^20.9.0",
+    "react": "^19.2.5",
+    "react-dom": "^19.2.5",
     "typescript": "^6.0.2"
   }
 }

docs/product-specs/platform.md

@@ -8,6 +8,8 @@ import { HttpInputError } from "../validation.ts";
 
 export const MIN_COMPARISON_RUNS = 2;
 export const MAX_COMPARISON_RUNS = 10;
+const RUN_ID_PATTERN =
+  /^(?:[0-9a-f]{32}|[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})$/i;
 
 export type ComparisonAlignment =
   | "preset_snapshot"
@@ -411,30 +413,41 @@ export function createComparisonController(options: {
       const trimmed = runIds
         .map((id) => (typeof id === "string" ? id.trim() : ""))
         .filter((id) => id.length > 0);
-      const deduped: string[] = [];
       const seen = new Set<string>();
       for (const id of trimmed) {
-        if (!seen.has(id)) {
-          seen.add(id);
-          deduped.push(id);
+        if (!RUN_ID_PATTERN.test(id)) {
+          throw new HttpInputError(
+            400,
+            "bad_request",
+            "run_ids must contain persisted run UUIDs.",
+          );
         }
+        const normalized = id.toLowerCase();
+        if (seen.has(normalized)) {
+          throw new HttpInputError(
+            400,
+            "bad_request",
+            "run_ids must not contain duplicates.",
+          );
+        }
+        seen.add(normalized);
       }
-      if (deduped.length < MIN_COMPARISON_RUNS) {
+      if (trimmed.length < MIN_COMPARISON_RUNS) {
         throw new HttpInputError(
           400,
           "bad_request",
-          `At least ${MIN_COMPARISON_RUNS} unique run_ids are required for comparison.`,
+          `At least ${MIN_COMPARISON_RUNS} run_ids are required for comparison.`,
         );
       }
-      if (deduped.length > MAX_COMPARISON_RUNS) {
+      if (trimmed.length > MAX_COMPARISON_RUNS) {
         throw new HttpInputError(
           400,
           "bad_request",
           `At most ${MAX_COMPARISON_RUNS} run_ids may be compared in a single request.`,
         );
       }
       const runs = await Promise.all(
-        deduped.map(async (runId) => {
+        trimmed.map(async (runId) => {
           const record = await repository.getRun(runId);
           if (!record) {
             throw new HttpInputError(