Skip to content

Commit e92d3f7

Browse files
committed
fix: widen ZW_Abort_SendRequest nodeid argument
The function parameter was `uint8_t`, so any LR node id (>= 256) was silently masked to its low byte before the comparison `s->param.snode == n`, where `s->param.snode` is `nodeid_t`. The match could never succeed for an LR session, leaving it queued until `request_timeout` fired. Relates-to: ZGW-3461 Signed-off-by: Laudin Molina Troconis <laudin.molinatroconis@silabs.com>
1 parent 9a77dd7 commit e92d3f7

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/transport/ZW_SendRequest.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ BYTE responseCmd, WORD timeout, void* user, ZW_SendRequst_Callback_t callback)
131131
return FALSE;
132132
}
133133

134-
void ZW_Abort_SendRequest(uint8_t n)
134+
void ZW_Abort_SendRequest(nodeid_t n)
135135
{
136136
// DBG_PRINTF("--------------- Inside ZW_Abort_SendRequest()\n");
137137
send_request_state_t* s;

src/transport/ZW_SendRequest.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ void ZW_SendRequest_init();
7575
* Abort send request for particular nodeid.
7676
* This command is used when removing the node. All pending Send Requests to that node need to be aborted.
7777
*/
78-
void ZW_Abort_SendRequest(uint8_t nodeid);
78+
void ZW_Abort_SendRequest(nodeid_t nodeid);
7979

8080
/**
8181
* @}

0 commit comments

Comments
 (0)