Skip to content

Commit 4bb5c82

Browse files
improve missing start_time error message
1 parent cfd91b0 commit 4bb5c82

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

src/silverlabnwb/nwb_file.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,11 @@ def create_from_metadata(self, metadata_file, user=None, session_id=None):
125125
try:
126126
start_time = sessions[user]['start_time']
127127
except KeyError:
128-
raise ValueError("Start time for session not found!")
128+
raise ValueError("Start time for session not found! "
129+
"Please add a `start_time` parameter to sessions for user {}, "
130+
"e.g. '10 May 2020 12:34:56.789103'"
131+
.format(user)
132+
)
129133
start_time = pd.to_datetime(
130134
start_time, infer_datetime_format=True).tz_localize(
131135
timezone('Europe/London'))

tests/test_metadata_import.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ def test_no_start_time_fails(tmpdir, ref_data_dir):
3232
with pytest.raises(ValueError) as exc_info:
3333
with NwbFile(nwb_path, 'w') as nwb:
3434
nwb.create_from_metadata(meta_path, user="A")
35-
assert "Start time for session not found!" == str(exc_info.value)
35+
expected_error_string = "Start time for session not found! " \
36+
"Please add a `start_time` parameter to sessions for user A, " \
37+
"e.g. '10 May 2020 12:34:56.789103'"
38+
assert expected_error_string == str(exc_info.value)
3639

3740

3841
def test_metadata_import_correct(tmpdir, ref_data_dir):

0 commit comments

Comments
 (0)